Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Unified Diff: runtime/lib/byte_array.dart

Issue 12033036: Fix native lookup. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/byte_array.cc ('k') | runtime/vm/bootstrap_natives.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/byte_array.dart
===================================================================
--- runtime/lib/byte_array.dart (revision 17469)
+++ runtime/lib/byte_array.dart (working copy)
@@ -8,13 +8,17 @@
}
/* patch */ factory Int8List.transferable(int length) {
- return new _Int8Array.transferable(length);
+ // return new _Int8Array.transferable(length);
+ return _newTransferable(length);
}
/* patch */ factory Int8List.view(ByteArray array,
[int start = 0, int length]) {
return new _Int8ArrayView(array, start, length);
}
+
+ static _ExternalInt8Array _newTransferable(int length)
+ native "Int8Array_newTransferable";
}
@@ -24,13 +28,16 @@
}
/* patch */ factory Uint8List.transferable(int length) {
- return new _Uint8Array.transferable(length);
+ return _newTransferable(length);
}
/* patch */ factory Uint8List.view(ByteArray array,
[int start = 0, int length]) {
return new _Uint8ArrayView(array, start, length);
}
+
+ static _ExternalUint8Array _newTransferable(int length)
+ native "Uint8Array_newTransferable";
}
@@ -40,13 +47,16 @@
}
/* patch */ factory Uint8ClampedList.transferable(int length) {
- return new _Uint8ClampedArray.transferable(length);
+ return _newTransferable(length);
}
/* patch */ factory Uint8ClampedList.view(ByteArray array,
[int start = 0, int length]) {
return new _Uint8ClampedArrayView(array, start, length);
}
+
+ static _ExternalUint8ClampedArray _newTransferable(int length)
+ native "Uint8ClampedArray_newTransferable";
}
@@ -56,13 +66,16 @@
}
/* patch */ factory Int16List.transferable(int length) {
- return new _Int16Array.transferable(length);
+ return _newTransferable(length);
}
/* patch */ factory Int16List.view(ByteArray array,
[int start = 0, int length]) {
return new _Int16ArrayView(array, start, length);
}
+
+ static _ExternalInt16Array _newTransferable(int length)
+ native "Int16Array_newTransferable";
}
@@ -72,13 +85,16 @@
}
/* patch */ factory Uint16List.transferable(int length) {
- return new _Uint16Array.transferable(length);
+ return _newTransferable(length);
}
/* patch */ factory Uint16List.view(ByteArray array,
[int start = 0, int length]) {
return new _Uint16ArrayView(array, start, length);
}
+
+ static _ExternalUint16Array _newTransferable(int length)
+ native "Uint16Array_newTransferable";
}
@@ -88,13 +104,16 @@
}
/* patch */ factory Int32List.transferable(int length) {
- return new _Int32Array.transferable(length);
+ return _newTransferable(length);
}
/* patch */ factory Int32List.view(ByteArray array,
[int start = 0, int length]) {
return new _Int32ArrayView(array, start, length);
}
+
+ static _ExternalInt32Array _newTransferable(int length)
+ native "Int32Array_newTransferable";
}
@@ -104,13 +123,16 @@
}
/* patch */ factory Uint32List.transferable(int length) {
- return new _Uint32Array.transferable(length);
+ return _newTransferable(length);
}
/* patch */ factory Uint32List.view(ByteArray array,
[int start = 0, int length]) {
return new _Uint32ArrayView(array, start, length);
}
+
+ static _ExternalUint32Array _newTransferable(int length)
+ native "Uint32Array_newTransferable";
}
@@ -120,13 +142,16 @@
}
/* patch */ factory Int64List.transferable(int length) {
- return new _Int64Array.transferable(length);
+ return _newTransferable(length);
}
/* patch */ factory Int64List.view(ByteArray array,
[int start = 0, int length]) {
return new _Int64ArrayView(array, start, length);
}
+
+ static _ExternalInt64Array _newTransferable(int length)
+ native "Int64Array_newTransferable";
}
@@ -136,13 +161,16 @@
}
/* patch */ factory Uint64List.transferable(int length) {
- return new _Uint64Array.transferable(length);
+ return _newTransferable(length);
}
/* patch */ factory Uint64List.view(ByteArray array,
[int start = 0, int length]) {
return new _Uint64ArrayView(array, start, length);
}
+
+ static _ExternalUint64Array _newTransferable(int length)
+ native "Uint64Array_newTransferable";
}
@@ -152,13 +180,16 @@
}
/* patch */ factory Float32List.transferable(int length) {
- return new _Float32Array.transferable(length);
+ return _newTransferable(length);
}
/* patch */ factory Float32List.view(ByteArray array,
[int start = 0, int length]) {
return new _Float32ArrayView(array, start, length);
}
+
+ static _ExternalFloat32Array _newTransferable(int length)
+ native "Float32Array_newTransferable";
}
@@ -168,13 +199,16 @@
}
/* patch */ factory Float64List.transferable(int length) {
- return new _Float64Array.transferable(length);
+ return _newTransferable(length);
}
/* patch */ factory Float64List.view(ByteArray array,
[int start = 0, int length]) {
return new _Float64ArrayView(array, start, length);
}
+
+ static _ExternalFloat64Array _newTransferable(int length)
+ native "Float64Array_newTransferable";
}
@@ -497,10 +531,6 @@
return _new(length);
}
- factory _Int8Array.transferable(int length) {
- return _newTransferable(length);
- }
-
factory _Int8Array.view(ByteArray array, [int start = 0, int length]) {
if (length == null) {
length = array.lengthInBytes();
@@ -553,8 +583,6 @@
static const int _BYTES_PER_ELEMENT = 1;
static _Int8Array _new(int length) native "Int8Array_new";
- static _Int8Array _newTransferable(int length)
- native "Int8Array_newTransferable";
int _getIndexed(int index) native "Int8Array_getIndexed";
int _setIndexed(int index, int value) native "Int8Array_setIndexed";
@@ -566,10 +594,6 @@
return _new(length);
}
- factory _Uint8Array.transferable(int length) {
- return _newTransferable(length);
- }
-
factory _Uint8Array.view(ByteArray array, [int start = 0, int length]) {
if (length == null) {
length = array.lengthInBytes();
@@ -623,8 +647,6 @@
static const int _BYTES_PER_ELEMENT = 1;
static _Uint8Array _new(int length) native "Uint8Array_new";
- static _Uint8Array _newTransferable(int length)
- native "Uint8Array_newTransferable";
int _getIndexed(int index) native "Uint8Array_getIndexed";
int _setIndexed(int index, int value) native "Uint8Array_setIndexed";
@@ -636,10 +658,6 @@
return _new(length);
}
- factory _Uint8ClampedArray.transferable(int length) {
- return _newTransferable(length);
- }
-
factory _Uint8ClampedArray.view(ByteArray array,
[int start = 0, int length]) {
if (length == null) {
@@ -694,8 +712,6 @@
static const int _BYTES_PER_ELEMENT = 1;
static _Uint8ClampedArray _new(int length) native "Uint8ClampedArray_new";
- static _Uint8ClampedArray _newTransferable(int length)
- native "Uint8ClampedArray_newTransferable";
int _getIndexed(int index) native "Uint8ClampedArray_getIndexed";
int _setIndexed(int index, int value) native "Uint8ClampedArray_setIndexed";
@@ -707,10 +723,6 @@
return _new(length);
}
- factory _Int16Array.transferable(int length) {
- return _newTransferable(length);
- }
-
factory _Int16Array.view(ByteArray array, [int start = 0, int length]) {
if (length == null) {
length = (array.lengthInBytes() - start) ~/ _BYTES_PER_ELEMENT;
@@ -763,8 +775,6 @@
static const int _BYTES_PER_ELEMENT = 2;
static _Int16Array _new(int length) native "Int16Array_new";
- static _Int16Array _newTransferable(int length)
- native "Int16Array_newTransferable";
int _getIndexed(int index) native "Int16Array_getIndexed";
int _setIndexed(int index, int value) native "Int16Array_setIndexed";
@@ -776,10 +786,6 @@
return _new(length);
}
- factory _Uint16Array.transferable(int length) {
- return _newTransferable(length);
- }
-
factory _Uint16Array.view(ByteArray array, [int start = 0, int length]) {
if (length == null) {
length = (array.lengthInBytes() - start) ~/ _BYTES_PER_ELEMENT;
@@ -832,8 +838,6 @@
static const int _BYTES_PER_ELEMENT = 2;
static _Uint16Array _new(int length) native "Uint16Array_new";
- static _Uint16Array _newTransferable(int length)
- native "Uint16Array_newTransferable";
int _getIndexed(int index) native "Uint16Array_getIndexed";
int _setIndexed(int index, int value) native "Uint16Array_setIndexed";
@@ -845,10 +849,6 @@
return _new(length);
}
- factory _Int32Array.transferable(int length) {
- return _newTransferable(length);
- }
-
factory _Int32Array.view(ByteArray array, [int start = 0, int length]) {
if (length == null) {
length = (array.lengthInBytes() - start) ~/ _BYTES_PER_ELEMENT;
@@ -901,8 +901,6 @@
static const int _BYTES_PER_ELEMENT = 4;
static _Int32Array _new(int length) native "Int32Array_new";
- static _Int32Array _newTransferable(int length)
- native "Int32Array_newTransferable";
int _getIndexed(int index) native "Int32Array_getIndexed";
@@ -915,10 +913,6 @@
return _new(length);
}
- factory _Uint32Array.transferable(int length) {
- return _newTransferable(length);
- }
-
factory _Uint32Array.view(ByteArray array, [int start = 0, int length]) {
if (length == null) {
length = (array.lengthInBytes() - start) ~/ _BYTES_PER_ELEMENT;
@@ -971,8 +965,6 @@
static const int _BYTES_PER_ELEMENT = 4;
static _Uint32Array _new(int length) native "Uint32Array_new";
- static _Uint32Array _newTransferable(int length)
- native "Uint32Array_newTransferable";
int _getIndexed(int index) native "Uint32Array_getIndexed";
int _setIndexed(int index, int value) native "Uint32Array_setIndexed";
@@ -984,10 +976,6 @@
return _new(length);
}
- factory _Int64Array.transferable(int length) {
- return _newTransferable(length);
- }
-
factory _Int64Array.view(ByteArray array, [int start = 0, int length]) {
if (length == null) {
length = (array.lengthInBytes() - start) ~/ _BYTES_PER_ELEMENT;
@@ -1040,8 +1028,6 @@
static const int _BYTES_PER_ELEMENT = 8;
static _Int64Array _new(int length) native "Int64Array_new";
- static _Int64Array _newTransferable(int length)
- native "Int64Array_newTransferable";
int _getIndexed(int index) native "Int64Array_getIndexed";
int _setIndexed(int index, int value) native "Int64Array_setIndexed";
@@ -1053,10 +1039,6 @@
return _new(length);
}
- factory _Uint64Array.transferable(int length) {
- return _newTransferable(length);
- }
-
factory _Uint64Array.view(ByteArray array, [int start = 0, int length]) {
if (length == null) {
length = (array.lengthInBytes() - start) ~/ _BYTES_PER_ELEMENT;
@@ -1109,8 +1091,6 @@
static const int _BYTES_PER_ELEMENT = 8;
static _Uint64Array _new(int length) native "Uint64Array_new";
- static _Uint64Array _newTransferable(int length)
- native "Uint64Array_newTransferable";
int _getIndexed(int index) native "Uint64Array_getIndexed";
int _setIndexed(int index, int value) native "Uint64Array_setIndexed";
@@ -1122,10 +1102,6 @@
return _new(length);
}
- factory _Float32Array.transferable(int length) {
- return _newTransferable(length);
- }
-
factory _Float32Array.view(ByteArray array, [int start = 0, int length]) {
if (length == null) {
length = (array.lengthInBytes() - start) ~/ _BYTES_PER_ELEMENT;
@@ -1178,8 +1154,6 @@
static const int _BYTES_PER_ELEMENT = 4;
static _Float32Array _new(int length) native "Float32Array_new";
- static _Float32Array _newTransferable(int length)
- native "Float32Array_newTransferable";
double _getIndexed(int index) native "Float32Array_getIndexed";
int _setIndexed(int index, double value) native "Float32Array_setIndexed";
@@ -1191,10 +1165,6 @@
return _new(length);
}
- factory _Float64Array.transferable(int length) {
- return _newTransferable(length);
- }
-
factory _Float64Array.view(ByteArray array, [int start = 0, int length]) {
if (length == null) {
length = (array.lengthInBytes() - start) ~/ _BYTES_PER_ELEMENT;
@@ -1247,8 +1217,6 @@
static const int _BYTES_PER_ELEMENT = 8;
static _Float64Array _new(int length) native "Float64Array_new";
- static _Float64Array _newTransferable(int length)
- native "Float64Array_newTransferable";
double _getIndexed(int index) native "Float64Array_getIndexed";
int _setIndexed(int index, double value) native "Float64Array_setIndexed";
« no previous file with comments | « runtime/lib/byte_array.cc ('k') | runtime/vm/bootstrap_natives.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698