Issue 12026013: Don't exit() in test_progress but rather set io.exitCode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12026013: Don't exit() in test_progress but rather set io.exitCode (Closed)

Created:
7 years, 11 months ago by kustermann

Modified:
7 years, 11 months ago

Reviewers:
ricow1, Mads Ager (google)

CC:
reviews_dartlang.org, ahe, Mads Ager (google)

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Don't exit() in test_progress but rather set io.exitCode Committed: https://code.google.com/p/dart/source/detail?r=17264

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	tools/testing/dart/test_progress.dart	View		3 chunks	+7 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

ricow1

LGTM Mads, there is not reason not to do this now right? - this should ...

7 years, 11 months ago (2013-01-18 10:14:49 UTC) #2

Mads Ager (google)

7 years, 11 months ago (2013-01-18 11:17:49 UTC) #4

Looks fantastic to me!

This is definitely the right thing to do. :)