Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: tools/testing/dart/test_progress.dart

Issue 12026013: Don't exit() in test_progress but rather set io.exitCode (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_progress.dart
diff --git a/tools/testing/dart/test_progress.dart b/tools/testing/dart/test_progress.dart
index cf3642454e05ba63e34d7463c01cb0968165d4f0..7a45a41b5443cd44b3e8081bbb18fbd302595d2f 100644
--- a/tools/testing/dart/test_progress.dart
+++ b/tools/testing/dart/test_progress.dart
@@ -5,6 +5,7 @@
library test_progress;
import "dart:io";
+import "dart:io" as io;
import "http_server.dart" as http_server;
import "status_file_parser.dart";
import "test_runner.dart";
@@ -110,7 +111,9 @@ class ProgressIndicator {
_printTimingInformation();
stdout.close();
stderr.close();
- if (_failedTests > 0) exit(1);
+ if (_failedTests > 0) {
+ io.exitCode = 1;
+ }
}
void _printStartProgress(TestCase test) {}
@@ -287,7 +290,9 @@ abstract class CompactIndicator extends ProgressIndicator {
}
stdout.close();
stderr.close();
- if (_failedTests > 0) exit(1);
+ if (_failedTests > 0) {
+ io.exitCode = 1;
+ }
}
void allTestsKnown() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698