Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12024002: Fixing cleanup of dart:html annotation generation. (Closed)

Created:
7 years, 11 months ago by blois
Modified:
7 years, 11 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixing cleanup of dart:html annotation generation. This is an update of https://codereview.chromium.org/11968047/ BUG= Committed: https://code.google.com/p/dart/source/detail?r=17323

Patch Set 1 #

Patch Set 2 : Fixing compiler issue (and indexed_db data issue) #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6797 lines, -3411 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 2 3 353 chunks +4139 lines, -2041 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 14 chunks +27 lines, -23 lines 0 comments Download
M sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart View 1 30 chunks +304 lines, -109 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 1 2 3 167 chunks +1884 lines, -942 lines 0 comments Download
M sdk/lib/web_audio/dart2js/web_audio_dart2js.dart View 22 chunks +218 lines, -109 lines 0 comments Download
M tools/dom/scripts/generator.py View 1 2 3 5 chunks +107 lines, -59 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 1 2 3 2 chunks +11 lines, -12 lines 0 comments Download
M tools/dom/scripts/systemnative.py View 1 2 3 1 chunk +5 lines, -8 lines 0 comments Download
M tools/dom/templates/dart2js_impl.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/dart2js/impl_ArrayBuffer.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/dart2js/impl_AudioBufferSourceNode.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/dart2js/impl_Console.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/dart2js/impl_HTMLTableElement.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/dart2js/impl_IDBDatabase.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/dart2js/impl_KeyboardEvent.darttemplate View 1 chunk +1 line, -2 lines 0 comments Download
M tools/dom/templates/html/dart2js/impl_MouseEvent.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/dart2js/impl_URL.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/dart2js/impl_Window.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/dart2js/impl_WorkerContext.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/dartium/dart_implementation.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/dartium/impl_KeyboardEvent.darttemplate View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/dom/templates/html/dartium/impl_MouseEvent.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/dartium/impl_Window.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_AudioContext.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Blob.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_CustomEvent.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Document.darttemplate View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_DocumentFragment.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Event.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_EventTarget.darttemplate View 3 chunks +4 lines, -4 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLCanvasElement.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLInputElement.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLSelectElement.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_History.darttemplate View 1 chunk +1 line, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_IDBFactory.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_IDBKeyRange.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_MutationObserver.darttemplate View 1 chunk +2 lines, -6 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Navigator.darttemplate View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Node.darttemplate View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Range.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_SVGElement.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_SVGSVGElement.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_ShadowRoot.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Storage.darttemplate View 1 chunk +3 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Text.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_UIEvent.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_WheelEvent.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate View 3 chunks +12 lines, -13 lines 0 comments Download
M tools/dom/templates/html/impl/pure_interface.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
Not sure exactly why the diff isn't working, but the basic changes are: Removed a ...
7 years, 11 months ago (2013-01-18 00:08:13 UTC) #1
blois
7 years, 11 months ago (2013-01-18 00:08:29 UTC) #2
sra1
7 years, 11 months ago (2013-01-18 21:52:07 UTC) #3 
lgtm

Powered by Google App Engine
This is Rietveld 408576698