Issue 12018023: Modify vm code base so that it can be built for --arch=simmips.

Issue 12018023: Modify vm code base so that it can be built for --arch=simmips. (Closed)

Created:
7 years, 11 months ago by regis

Modified:
7 years, 11 months ago

Reviewers:
siva, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Mofify vm code base so that it can be built for --arch=simmips. Committed: https://code.google.com/p/dart/source/detail?r=17321

Patch Set 2 : #

Total comments: 4

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -18 lines)			Patch
M	runtime/vm/assembler.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_macros.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/cpu_test.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/elfgen.h	View	1	2 chunks	+6 lines, -2 lines	4 comments	Download
M	runtime/vm/instructions.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/os_linux.cc	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	runtime/vm/vm_sources.gypi	View	1	11 chunks	+22 lines, -4 lines	0 comments	Download
M	tools/gyp/configurations.gypi	View	1	2 chunks	+2 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

DBC -ip https://codereview.chromium.org/12018023/diff/7001/runtime/vm/elfgen.h File runtime/vm/elfgen.h (right): https://codereview.chromium.org/12018023/diff/7001/runtime/vm/elfgen.h#newcode345 runtime/vm/elfgen.h:345: #if defined(TARGET_ARCH_IA32) || \ Should this be ...

7 years, 11 months ago (2013-01-18 23:57:39 UTC) #3

regis

7 years, 11 months ago (2013-01-19 00:17:34 UTC) #4

Message was sent while issue was closed.

Thanks

https://codereview.chromium.org/12018023/diff/7001/runtime/vm/elfgen.h
File runtime/vm/elfgen.h (right):

https://codereview.chromium.org/12018023/diff/7001/runtime/vm/elfgen.h#newcod...
runtime/vm/elfgen.h:345: #if defined(TARGET_ARCH_IA32) ||                       
                       \
On 2013/01/18 23:57:39, Ivan Posva wrote:
> Should this be ARCH_IS_32_BIT and ARCH_IS_64_BIT, instead of listing all
> architectures here?

Good point. I'll fix that in a later cl with other comments you may have.

https://codereview.chromium.org/12018023/diff/7001/runtime/vm/elfgen.h#newcod...
runtime/vm/elfgen.h:390: defined(TARGET_ARCH_MIPS)
ditto

https://codereview.chromium.org/12018023/diff/7001/runtime/vm/elfgen.h#newcod...
runtime/vm/elfgen.h:407: #endif
I will handle MIPS here as well.

Expand Messages | Collapse Messages