runtime/vm/elfgen.h - Issue 12018023: Modify vm code base so that it can be built for --arch=simmips.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/elfgen.h

Issue 12018023: Modify vm code base so that it can be built for --arch=simmips. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/elfgen.h

===================================================================

--- runtime/vm/elfgen.h (revision 17318)

+++ runtime/vm/elfgen.h (working copy)

@@ -342,7 +342,9 @@

#endif

WriteWord(symtab, pc); // st_value

WriteWord(symtab, size); // st_size

-#if defined(TARGET_ARCH_IA32) || defined(TARGET_ARCH_ARM)

+#if defined(TARGET_ARCH_IA32) || \

Ivan Posva 2013/01/18 23:57:39 Should this be ARCH_IS_32_BIT and ARCH_IS_64_BIT,

regis 2013/01/19 00:17:34 Good point. I'll fix that in a later cl with other

+ defined(TARGET_ARCH_ARM) || \

+ defined(TARGET_ARCH_MIPS)

// st_info + (st_other<<8)

WriteShort(symtab, (kSTB_EXPORTED << 4) + kSTT_FUNC);

WriteShort(symtab, kText); // st_shndx

@@ -383,7 +385,9 @@

void ElfGen::AddELFHeader(int shoff) {

ASSERT(text_vma_ != 0); // Code must have been added.

Write(&header_, kEI_MAG0_MAG3, 4); // EI_MAG0..EI_MAG3

-#if defined(TARGET_ARCH_IA32) || defined(TARGET_ARCH_ARM)

+#if defined(TARGET_ARCH_IA32) || \

+ defined(TARGET_ARCH_ARM) || \

+ defined(TARGET_ARCH_MIPS)

regis 2013/01/19 00:17:34 ditto

WriteByte(&header_, kELFCLASS32); // EI_CLASS

#elif defined(TARGET_ARCH_X64)

WriteByte(&header_, kELFCLASS64); // EI_CLASS

« no previous file with comments | « runtime/vm/cpu_test.cc ('k') | runtime/vm/instructions.h » ('j') | no next file with comments »