Issue 1201753004: Revert "dart2js cps: Refactor and optimize string concatenations."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1201753004: Revert "dart2js cps: Refactor and optimize string concatenations." (Closed)

Created:
5 years, 6 months ago by asgerf

Modified:
5 years, 6 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Revert "dart2js cps: Refactor and optimize string concatenations." This reverts commit ac75893964144d5712d1da8417c27c232750ec37. TBR=kmillikin@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/988b65336b3194cd539781195a9b8be24b3bbdc3

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+341 lines, -236 lines)			Patch
M	pkg/compiler/lib/src/constants/expressions.dart	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/builtin_operator.dart	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart	View	6 chunks	+36 lines, -26 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart	View	11 chunks	+39 lines, -55 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart	View	4 chunks	+22 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart	View	2 chunks	+11 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/type_propagation.dart	View	11 chunks	+134 lines, -138 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/codegen/codegen.dart	View	2 chunks	+25 lines, -3 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/codegen/unsugar.dart	View	1 chunk	+9 lines, -3 lines	0 comments	Download
M	pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart	View	2 chunks	+7 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart	View	5 chunks	+28 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

asgerf

5 years, 6 months ago (2015-06-22 17:34:17 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
988b65336b3194cd539781195a9b8be24b3bbdc3 (presubmit successful).

Expand Messages | Collapse Messages