Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/unsugar.dart

Issue 1201753004: Revert "dart2js cps: Refactor and optimize string concatenations." (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/codegen/unsugar.dart
diff --git a/pkg/compiler/lib/src/js_backend/codegen/unsugar.dart b/pkg/compiler/lib/src/js_backend/codegen/unsugar.dart
index 494828e8cd9909f5cf028e6b0dcf70559fb74ff0..045e7664a039764ab37e32a628d66fd21b20b9d9 100644
--- a/pkg/compiler/lib/src/js_backend/codegen/unsugar.dart
+++ b/pkg/compiler/lib/src/js_backend/codegen/unsugar.dart
@@ -82,15 +82,21 @@ class UnsugarVisitor extends RecursiveVisitor {
}
Constant get trueConstant {
- return new Constant(new TrueConstantValue());
+ return new Constant(
+ new BoolConstantExpression(true),
+ new TrueConstantValue());
}
Constant get falseConstant {
- return new Constant(new FalseConstantValue());
+ return new Constant(
+ new BoolConstantExpression(false),
+ new FalseConstantValue());
}
Constant get nullConstant {
- return new Constant(new NullConstantValue());
+ return new Constant(
+ new NullConstantExpression(),
+ new NullConstantValue());
}
void insertLetPrim(Primitive primitive, Expression node) {

Powered by Google App Engine
This is Rietveld 408576698