Issue 11975017: Stop treating StreamController as a Stream.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11975017: Stop treating StreamController as a Stream. (Closed)

Created:
7 years, 11 months ago by nweiz

Modified:
7 years, 11 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Stop treating StreamController as a Stream. Apparently StreamController will soon stop extending Stream, so this gets rid of all uses of it as a Stream in pkg/http and pub. Committed: https://code.google.com/p/dart/source/detail?r=17163

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -35 lines)			Patch
M	pkg/http/lib/src/multipart_request.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/http/lib/src/streamed_request.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/http/lib/src/utils.dart	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	pkg/http/test/mock_client_test.dart	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	pkg/http/test/multipart_test.dart	View	3 chunks	+7 lines, -7 lines	0 comments	Download
M	pkg/http/test/response_test.dart	View	1 chunk	+10 lines, -9 lines	0 comments	Download
M	utils/pub/error_group.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	utils/tests/pub/error_group_test.dart	View	6 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM!

Expand Messages | Collapse Messages