Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Side by Side Diff: utils/pub/error_group.dart

Issue 11975017: Stop treating StreamController as a Stream. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « pkg/http/test/response_test.dart ('k') | utils/tests/pub/error_group_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library error_group; 5 library error_group;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 8
9 /// An [ErrorGroup] entangles the errors of multiple [Future]s and [Stream]s 9 /// An [ErrorGroup] entangles the errors of multiple [Future]s and [Stream]s
10 /// with one another. This allows APIs to expose multiple [Future]s and 10 /// with one another. This allows APIs to expose multiple [Future]s and
(...skipping 230 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 onDone: () { 241 onDone: () {
242 _isDone = true; 242 _isDone = true;
243 _group._signalStreamComplete(this); 243 _group._signalStreamComplete(this);
244 _controller.close(); 244 _controller.close();
245 }); 245 });
246 } 246 }
247 247
248 StreamSubscription listen(void onData(value), 248 StreamSubscription listen(void onData(value),
249 {void onError(AsyncError error), void onDone(), 249 {void onError(AsyncError error), void onDone(),
250 bool unsubscribeOnError}) { 250 bool unsubscribeOnError}) {
251 return _controller.listen(onData, 251 return _controller.stream.listen(onData,
252 onError: onError, 252 onError: onError,
253 onDone: onDone, 253 onDone: onDone,
254 unsubscribeOnError: true); 254 unsubscribeOnError: true);
255 } 255 }
256 256
257 /// Signal that an error from [_group] should be propagated through [this], 257 /// Signal that an error from [_group] should be propagated through [this],
258 /// unless it's already complete. 258 /// unless it's already complete.
259 void _signalError(AsyncError e) { 259 void _signalError(AsyncError e) {
260 if (_isDone) return; 260 if (_isDone) return;
261 _subscription.cancel(); 261 _subscription.cancel();
262 // Call these asynchronously to work around issue 7913. 262 // Call these asynchronously to work around issue 7913.
263 new Future.immediate(null).then((_) { 263 new Future.immediate(null).then((_) {
264 _controller.signalError(e.error, e.stackTrace); 264 _controller.signalError(e.error, e.stackTrace);
265 _controller.close(); 265 _controller.close();
266 }); 266 });
267 } 267 }
268 } 268 }
OLDNEW
« no previous file with comments | « pkg/http/test/response_test.dart ('k') | utils/tests/pub/error_group_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698