Issue 11970007: Address Erik's comments on https://codereview.chromium.org/11778064 and fix minifier failures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11970007: Address Erik's comments on https://codereview.chromium.org/11778064 and fix minifier failures. (Closed)

Created:
7 years, 11 months ago by ngeoffray

Modified:
7 years, 11 months ago

Reviewers:
erikcorry

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Address Erik's comments on https://codereview.chromium.org/11778064 and fix minifier failures. Committed: https://code.google.com/p/dart/source/detail?r=17131

Patch Set 1 #

Total comments: 1

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -5 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart	View		2 chunks	+6 lines, -4 lines	1 comment	Download
	M	sdk/lib/_internal/compiler/implementation/lib/js_helper.dart	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

https://codereview.chromium.org/11970007/diff/1/sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart File sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart (left): https://codereview.chromium.org/11970007/diff/1/sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart#oldcode411 sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart:411: && !new RegExp('client.dart\.js').hasMatch(src)) { The path has now changed. ...

7 years, 11 months ago (2013-01-16 10:33:38 UTC) #1

lgtm

Expand Messages | Collapse Messages