Issue 1196413003: Add a LoadSuite class.

Issue 1196413003: Add a LoadSuite class. (Closed)

Created:
5 years, 6 months ago by nweiz

Modified:
5 years, 6 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/test@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add a LoadSuite class. This class exposes the progress of a loading a test file in a way that can be easily displayed by reporters. It also allows us to start running some tests while others are still loading. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/2f30ecb2f718dddd81933d113d4cb6c76b142e75

Patch Set 1 #

Total comments: 4

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+696 lines, -291 lines)			Patch
M	lib/src/backend/invoker.dart	View	2 chunks	+7 lines, -5 lines	0 comments	Download
M	lib/src/executable.dart	View	7 chunks	+31 lines, -18 lines	0 comments	Download
M	lib/src/runner/browser/browser_manager.dart	View	1 chunk	+12 lines, -2 lines	0 comments	Download
M	lib/src/runner/browser/compiler_pool.dart	View	5 chunks	+34 lines, -73 lines	0 comments	Download
M	lib/src/runner/browser/iframe_listener.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	lib/src/runner/engine.dart	View	6 chunks	+91 lines, -4 lines	0 comments	Download
A	lib/src/runner/load_suite.dart	View	1 chunk	+113 lines, -0 lines	4 comments	Download
M	lib/src/runner/loader.dart	View	7 chunks	+55 lines, -32 lines	0 comments	Download
M	lib/src/runner/reporter/compact.dart	View	7 chunks	+27 lines, -9 lines	0 comments	Download
M	lib/src/runner/reporter/expanded.dart	View	6 chunks	+32 lines, -10 lines	0 comments	Download
M	lib/src/runner/vm/isolate_listener.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	lib/src/utils.dart	View	1 chunk	+6 lines, -0 lines	0 comments	Download
D	test/runner/browser/compiler_pool_test.dart	View	1 chunk	+0 lines, -61 lines	0 comments	Download
M	test/runner/browser/firefox_test.dart	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	test/runner/browser/loader_test.dart	View	4 chunks	+23 lines, -3 lines	0 comments	Download
M	test/runner/browser/runner_test.dart	View	12 chunks	+44 lines, -31 lines	0 comments	Download
M	test/runner/compact_reporter_test.dart	View	12 chunks	+12 lines, -1 line	0 comments	Download
M	test/runner/expanded_reporter_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
A	test/runner/load_suite_test.dart	View	1 chunk	+123 lines, -0 lines	0 comments	Download
M	test/runner/loader_test.dart	View	3 chunks	+25 lines, -2 lines	0 comments	Download
M	test/runner/pub_serve_test.dart	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	test/runner/runner_test.dart	View	12 chunks	+13 lines, -13 lines	0 comments	Download
M	test/runner/signal_test.dart	View	8 chunks	+32 lines, -18 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kevmoo

lgtm https://codereview.chromium.org/1196413003/diff/1/lib/src/runner/load_suite.dart File lib/src/runner/load_suite.dart (right): https://codereview.chromium.org/1196413003/diff/1/lib/src/runner/load_suite.dart#newcode21 lib/src/runner/load_suite.dart:21: /// This is used to expose the current ...

5 years, 6 months ago (2015-06-23 00:48:06 UTC) #2

nweiz

https://codereview.chromium.org/1196413003/diff/1/lib/src/runner/load_suite.dart File lib/src/runner/load_suite.dart (right): https://codereview.chromium.org/1196413003/diff/1/lib/src/runner/load_suite.dart#newcode21 lib/src/runner/load_suite.dart:21: /// This is used to expose the current status ...

5 years, 6 months ago (2015-06-23 19:38:54 UTC) #3

nweiz

5 years, 6 months ago (2015-06-23 19:39:16 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2f30ecb2f718dddd81933d113d4cb6c76b142e75 (presubmit successful).

Expand Messages | Collapse Messages