Add a LoadSuite class.

lib/src/runner/loader.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.runner.loader;
 
 import 'dart:async';
 import 'dart:io';
 import 'dart:isolate';
 
 import 'package:analyzer/analyzer.dart';
 import 'package:path/path.dart' as p;
+import 'package:stack_trace/stack_trace.dart';
 
 import '../backend/invoker.dart';
 import '../backend/metadata.dart';
 import '../backend/suite.dart';
 import '../backend/test_platform.dart';
 import '../util/async_thunk.dart';
 import '../util/dart.dart' as dart;
 import '../util/io.dart';
 import '../util/isolate_wrapper.dart';
 import '../util/remote_exception.dart';
 import '../utils.dart';
 import 'browser/server.dart';
 import 'load_exception.dart';
+import 'load_suite.dart';
 import 'parse_metadata.dart';
 import 'vm/isolate_test.dart';
 
 /// A class for finding test files and loading them into a runnable form.
 class Loader {
   /// All platforms for which tests should be loaded.
   final List<TestPlatform> _platforms;
 
   /// Whether to enable colors for Dart compilation.
   final bool _color;
@@ skipping 61 matching lines @@
         _root = root == null ? p.current : root,
         _packageRoot = packageRootFor(root, packageRoot),
         _color = color,
         _jsTrace = jsTrace,
         _metadata = metadata == null ? new Metadata() : metadata;
 
   /// Loads all test suites in [dir].
   ///
   /// This will load tests from files that end in "_test.dart". Any tests that
   /// fail to load will be emitted as [LoadException]s.
-  Stream<Suite> loadDir(String dir) {
+  ///
+  /// This emits [LoadSuite]s that must then be run to emit the actual [Suite]s
+  /// defined in the file.
+  Stream<LoadSuite> loadDir(String dir) {
     return mergeStreams(new Directory(dir).listSync(recursive: true)
         .map((entry) {
       if (entry is! File) return new Stream.fromIterable([]);
 
       if (!entry.path.endsWith("_test.dart")) {
         return new Stream.fromIterable([]);
       }
 
       if (p.split(entry.path).contains('packages')) {
          return new Stream.fromIterable([]);
       }
 
       return loadFile(entry.path);
     }));
   }
 
   /// Loads a test suite from the file at [path].
   ///
+  /// This emits [LoadSuite]s that must then be run to emit the actual [Suite]s
+  /// defined in the file.
+  ///
   /// This will emit a [LoadException] if the file fails to load.
-  Stream<Suite> loadFile(String path) async* {
+  Stream<LoadSuite> loadFile(String path) async* {
     var suiteMetadata;
     try {
       suiteMetadata = parseMetadata(path);
     } on AnalyzerErrorGroup catch (_) {
       // Ignore the analyzer's error, since its formatting is much worse than
       // the VM's or dart2js's.
       suiteMetadata = new Metadata();
     } on FormatException catch (error, stackTrace) {
-      await new Future.error(new LoadException(path, error), stackTrace);
+      yield new LoadSuite.forLoadException(
+          new LoadException(path, error), stackTrace: stackTrace);
+      return;
     }
     suiteMetadata = _metadata.merge(suiteMetadata);
 
+    if (_pubServeUrl != null && !p.isWithin('test', path)) {
+      yield new LoadSuite.forLoadException(new LoadException(
+          path, 'When using "pub serve", all test files must be in test/.'));
+      return;
+    }
+
     for (var platform in _platforms) {
       if (!suiteMetadata.testOn.evaluate(platform, os: currentOS)) continue;
 
       var metadata = suiteMetadata.forPlatform(platform, os: currentOS);
 
       // Don't load a skipped suite.
       if (metadata.skip) {
-        yield new Suite([
+        yield new LoadSuite.forSuite(new Suite([
           new LocalTest(path, metadata, () {})
-        ], path: path, platform: platform.name, metadata: metadata);
+        ], path: path, platform: platform.name, metadata: metadata));
         continue;
       }
 
-      try {
-        if (_pubServeUrl != null && !p.isWithin('test', path)) {
-          throw new LoadException(path,
-              'When using "pub serve", all test files must be in test/.');
-        }
-
-        var suite = platform == TestPlatform.vm
-            ? await _loadVmFile(path, metadata)
-            : await _loadBrowserFile(path, platform, metadata);
-        if (suite != null) yield suite;
-      } catch (error, stackTrace) {
-        yield* errorStream(error, stackTrace);
-      }
+      var name = (platform.isJS ? "compiling " : "loading ") + path;
+      yield new LoadSuite(name, () {
+        return platform == TestPlatform.vm
+            ? _loadVmFile(path, metadata)
+            : _loadBrowserFile(path, platform, metadata);
+      }, platform: platform.name);
     }
   }
 
   /// Load the test suite at [path] in [platform].
   ///
   /// [metadata] is the suite-level metadata for the test.
   Future<Suite> _loadBrowserFile(String path, TestPlatform platform,
         Metadata metadata) async =>
       (await _browserServer).loadSuite(path, platform, metadata);
 
@@ skipping 49 matching lines @@
           'metadata': metadata.serialize()
         }, packageRoot: p.toUri(_packageRoot), checked: true);
       }
     } catch (error, stackTrace) {
       receivePort.close();
       if (error is LoadException) rethrow;
       await new Future.error(new LoadException(path, error), stackTrace);
     }
 
     _isolates.add(isolate);
-    var response = await receivePort.first;
 
-    if (response["type"] == "loadException") {
-      throw new LoadException(path, response["message"]);
-    } else if (response["type"] == "error") {
-      var asyncError = RemoteException.deserialize(response["error"]);
-      await new Future.error(
-          new LoadException(path, asyncError.error),
-          asyncError.stackTrace);
+    var completer = new Completer();
+
+    var subscription = receivePort.listen((response) {
+      if (response["type"] == "print") {
+        print(response["line"]);
+      } else if (response["type"] == "loadException") {
+        completer.completeError(
+            new LoadException(path, response["message"]),
+            new Trace.current());
+      } else if (response["type"] == "error") {
+        var asyncError = RemoteException.deserialize(response["error"]);
+        completer.completeError(
+            new LoadException(path, asyncError.error),
+            asyncError.stackTrace);
+      } else {
+        assert(response["type"] == "success");
+        completer.complete(response["tests"]);
+      }
+    });
+
+    try {
+      return new Suite((await completer.future).map((test) {
+        var testMetadata = new Metadata.deserialize(test['metadata']);
+        return new IsolateTest(test['name'], testMetadata, test['sendPort']);
+      }), metadata: metadata, path: path, platform: "VM");
+    } finally {
+      subscription.cancel();
     }
-
-    return new Suite(response["tests"].map((test) {
-      var testMetadata = new Metadata.deserialize(test['metadata']);
-      return new IsolateTest(test['name'], testMetadata, test['sendPort']);
-    }), metadata: metadata, path: path, platform: "VM");
   }
 
   /// Closes the loader and releases all resources allocated by it.
   Future close() {
     return _closeThunk.run(() async {
       for (var isolate in _isolates) {
         isolate.kill();
       }
       _isolates.clear();
 
       if (!_browserServerThunk.hasRun) return;
       await (await _browserServer).close();
     });
   }
 }