Issue 11962042: Added DebugLogger to testing scripts.

Issue 11962042: Added DebugLogger to testing scripts. (Closed)

Created:
7 years, 11 months ago by kustermann

Modified:
7 years, 11 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org, ahe

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Added DebugLogger to testing scripts. Committed: https://code.google.com/p/dart/source/detail?r=17291

Patch Set 3 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -11 lines)			Patch
M	.gitignore	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/bots/compiler.py	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	tools/test.dart	View	1 2	3 chunks	+11 lines, -2 lines	0 comments	Download
M	tools/test-runtime.dart	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/testing/dart/test_options.dart	View	1	1 chunk	+11 lines, -3 lines	0 comments	Download
M	tools/testing/dart/test_runner.dart	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
M	tools/testing/dart/test_suite.dart	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	tools/testing/dart/utils.dart	View	1	1 chunk	+42 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ricow1

LGTM https://codereview.chromium.org/11962042/diff/1/tools/test.dart File tools/test.dart (right): https://codereview.chromium.org/11962042/diff/1/tools/test.dart#newcode93 tools/test.dart:93: DebugLogger.init(firstConf['write_debug_log'] ? write_debug_log -> write_debug_log_to_file ? https://codereview.chromium.org/11962042/diff/1/tools/testing/dart/test_progress.dart File ...

7 years, 11 months ago (2013-01-17 17:07:38 UTC) #2

kustermann

PTAL https://codereview.chromium.org/11962042/diff/1/tools/testing/dart/test_progress.dart File tools/testing/dart/test_progress.dart (right): https://codereview.chromium.org/11962042/diff/1/tools/testing/dart/test_progress.dart#newcode111 tools/testing/dart/test_progress.dart:111: DebugLogger.close(); On 2013/01/17 17:07:38, ricow1 wrote: > I ...

7 years, 11 months ago (2013-01-17 17:33:17 UTC) #3

kustermann

7 years, 11 months ago (2013-01-18 09:03:25 UTC) #4

https://codereview.chromium.org/11962042/diff/1/tools/test.dart
File tools/test.dart (right):

https://codereview.chromium.org/11962042/diff/1/tools/test.dart#newcode93
tools/test.dart:93: DebugLogger.init(firstConf['write_debug_log'] ?
On 2013/01/17 17:07:38, ricow1 wrote:
> write_debug_log -> write_debug_log_to_file ?

This way the name is the same as the command line parameter. So I'd keep it.
(and write_debug_log_to_file would be pretty long for a command line parameter)

Expand Messages | Collapse Messages