Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: tools/test.dart

Issue 11962042: Added DebugLogger to testing scripts. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/bots/compiler.py ('k') | tools/test-runtime.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/test.dart
diff --git a/tools/test.dart b/tools/test.dart
index 2dc3aaa917deed87389070b6e8e9b74391f31834..b1ce567899045096cb01546b550a9b362b787fa1 100755
--- a/tools/test.dart
+++ b/tools/test.dart
@@ -30,6 +30,7 @@ import "testing/dart/test_options.dart";
import "testing/dart/test_suite.dart";
import "testing/dart/test_progress.dart";
import "testing/dart/http_server.dart";
+import "testing/dart/utils.dart";
import "../compiler/tests/dartc/test_config.dart";
import "../runtime/tests/vm/test_config.dart";
@@ -82,13 +83,16 @@ main() {
var printTiming = firstConf['time'];
var listTests = firstConf['list'];
- if (!firstConf['append_flaky_log']) {
+ if (!firstConf['append_logs']) {
var file = new File(TestUtils.flakyFileName());
if (file.existsSync()) {
file.deleteSync();
}
}
+ DebugLogger.init(firstConf['write_debug_log'] ?
+ TestUtils.debugLogfile() : null, append: firstConf['append_logs']);
+
// Print the configurations being run by this execution of
// test.dart. However, don't do it if the silent progress indicator
// is used. This is only needed because of the junit tests.
@@ -146,13 +150,18 @@ main() {
}
}
+ void allTestsFinished() {
+ TestingServerRunner.terminateHttpServers();
+ DebugLogger.close();
+ }
+
// Start process queue.
new ProcessQueue(maxProcesses,
progressIndicator,
startTime,
printTiming,
testSuites,
- () => TestingServerRunner.terminateHttpServers(),
+ allTestsFinished,
verbose,
listTests);
}
« no previous file with comments | « tools/bots/compiler.py ('k') | tools/test-runtime.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698