Issue 11953047: Fix host checked mode failure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11953047: Fix host checked mode failure. (Closed)

Created:
7 years, 11 months ago by ngeoffray

Modified:
7 years, 11 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix host checked mode failure. Committed: https://code.google.com/p/dart/source/detail?r=17452

Patch Set 3 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -26 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/ssa/nodes.dart	View	1 2	4 chunks	+37 lines, -26 lines	0 comments	Download
	M	tests/compiler/dart2js/gvn_test.dart	View	1 2	2 chunks	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://codereview.chromium.org/11953047/diff/7001/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart File sdk/lib/_internal/compiler/implementation/ssa/nodes.dart (left): https://codereview.chromium.org/11953047/diff/7001/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart#oldcode792 sdk/lib/_internal/compiler/implementation/ssa/nodes.dart:792: static const int INVOKE_DYNAMIC_GETTER_TYPECODE = 31; No more ...

7 years, 11 months ago (2013-01-23 12:38:04 UTC) #2

ngeoffray

Thanks Kasper. https://codereview.chromium.org/11953047/diff/7001/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart File sdk/lib/_internal/compiler/implementation/ssa/nodes.dart (left): https://codereview.chromium.org/11953047/diff/7001/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart#oldcode792 sdk/lib/_internal/compiler/implementation/ssa/nodes.dart:792: static const int INVOKE_DYNAMIC_GETTER_TYPECODE = 31; On ...

7 years, 11 months ago (2013-01-23 12:42:23 UTC) #3

Even better. LGTM.

Expand Messages | Collapse Messages

Issue 11953047: Fix host checked mode failure. (Closed)

Description

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Messages