Fix host checked mode failure.

sdk/lib/_internal/compiler/implementation/ssa/nodes.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of ssa;
 
 abstract class HVisitor<R> {
   R visitAdd(HAdd node);
   R visitBailoutTarget(HBailoutTarget node);
   R visitBitAnd(HBitAnd node);
@@ skipping 771 matching lines @@
   static const int GREATER_TYPECODE = 21;
   static const int GREATER_EQUAL_TYPECODE = 22;
   static const int LESS_TYPECODE = 23;
   static const int LESS_EQUAL_TYPECODE = 24;
   static const int STATIC_TYPECODE = 25;
   static const int STATIC_STORE_TYPECODE = 26;
   static const int FIELD_GET_TYPECODE = 27;
   static const int TYPE_CONVERSION_TYPECODE = 28;
   static const int BAILOUT_TARGET_TYPECODE = 29;
   static const int INVOKE_STATIC_TYPECODE = 30;
-  static const int INVOKE_DYNAMIC_GETTER_TYPECODE = 31;

[kasperl, 2013/01/23 12:38:04]

No more use of 31?

[ngeoffray, 2013/01/23 12:42:23]

No, as well as others. I have updated the constants to remove holes.

   static const int INDEX_TYPECODE = 32;
+  static const int IS_TYPECODE = 33;
+  static const int INVOKE_DYNAMIC_TYPECODE = 34;
 
   HInstruction(this.inputs) : id = idCounter++, usedBy = <HInstruction>[];
 
   int get hashCode => id;
 
   bool getFlag(int position) => (flags & (1 << position)) != 0;
   void setFlag(int position) { flags |= (1 << position); }
   void clearFlag(int position) { flags &= ~(1 << position); }
 
   static int computeDependsOnFlags(int flags) => flags << FLAG_CHANGES_COUNT;
@@ skipping 516 matching lines @@
     : super(inputs);
   toString() => 'invoke dynamic: $selector';
   HInstruction get receiver => inputs[0];
 
   bool get isInterceptorCall {
     // We know it's a selector call if it follows the interceptor
     // calling convention, which adds the actual receiver as a
     // parameter to the call.
     return inputs.length - 2 == selector.argumentCount;
   }
+
+  int typeCode() => HInstruction.INVOKE_DYNAMIC_TYPECODE;
+  bool typeEquals(other) => other is HInvokeDynamic;
+  bool dataEquals(HInvokeDynamic other) {
+    return selector == other.selector
+        && element == other.element;
+  }
 }
 
 class HInvokeClosure extends HInvokeDynamic {
   HInvokeClosure(Selector selector, List<HInstruction> inputs)
     : super(selector, null, inputs) {
     assert(selector.isClosureCall());
   }
   accept(HVisitor visitor) => visitor.visitInvokeClosure(this);
 }
 
@@ skipping 43 matching lines @@
     if (isSideEffectFree) {
       setUseGvn();
       setDependsOnInstancePropertyStore();
     } else {
       setDependsOnSomething();
       setAllSideEffects();
     }
   }
   toString() => 'invoke dynamic getter: $selector';
   accept(HVisitor visitor) => visitor.visitInvokeDynamicGetter(this);
-
-  int typeCode() => HInstruction.INVOKE_DYNAMIC_GETTER_TYPECODE;
-  bool typeEquals(other) => other is HInvokeDynamicGetter;
-  bool dataEquals(HInvokeDynamicGetter other) => selector == other.selector;
 }
 
 class HInvokeDynamicSetter extends HInvokeDynamicField {
   HInvokeDynamicSetter(selector, element, receiver, value, isSideEffectFree)
     : super(selector, element, [receiver, value], isSideEffectFree) {
     clearAllSideEffects();
     if (isSideEffectFree) {
       setChangesInstanceProperty();
     } else {
       setAllSideEffects();
@@ skipping 823 matching lines @@
   HInstruction getCheck(int index) => inputs[index + 1];
   int get checkCount => inputs.length - 1;
 
   bool hasArgumentChecks() => inputs.length > 1;
 
   HType get guaranteedType => HType.BOOLEAN;
 
   accept(HVisitor visitor) => visitor.visitIs(this);
 
   toString() => "$expression is $typeExpression";
+
+  int typeCode() => HInstruction.IS_TYPECODE;
+  bool typeEquals(HInstruction other) => other is HIs;
+  bool dataEquals(HIs other) {
+    return typeExpression == other.typeExpression
+        && nullOk == other.nullOk;
+  }
 }
 
 class HTypeConversion extends HCheck {
   HType type;
   final int kind;
 
   static const int NO_CHECK = 0;
   static const int CHECKED_MODE_CHECK = 1;
   static const int ARGUMENT_TYPE_CHECK = 2;
   static const int CAST_TYPE_CHECK = 3;
@@ skipping 385 matching lines @@
   HBasicBlock get start => expression.start;
   HBasicBlock get end {
     // We don't create a switch block if there are no cases.
     assert(!statements.isEmpty);
     return statements.last.end;
   }
 
   bool accept(HStatementInformationVisitor visitor) =>
       visitor.visitSwitchInfo(this);
 }