Make VirtualDirectory redirect if the directory-path does not end with a tailing slash.

Make VirtualDirectory redirect if the directory-path does not end with a tailing slash.

BUG=https://code.google.com/p/dart/issues/detail?id=15764
R=sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=31651

[Søren Gjesse, 2014-01-06 13:18:08]

LGTM with comments

https://codereview.chromium.org/119453005/diff/1/pkg/http_server/lib/src/virt...
File pkg/http_server/lib/src/virtual_directory.dart (right):

https://codereview.chromium.org/119453005/diff/1/pkg/http_server/lib/src/virt...
pkg/http_server/lib/src/virtual_directory.dart:81:
request.response.redirect(Uri.parse('${request.uri}/'),
According to RFC 2616 section 14.30 the redirect location should be an absolute
URI.

[Anders Johnsen, 2014-01-09 09:32:25]

PTAL

https://codereview.chromium.org/119453005/diff/1/pkg/http_server/lib/src/virt...
File pkg/http_server/lib/src/virtual_directory.dart (right):

https://codereview.chromium.org/119453005/diff/1/pkg/http_server/lib/src/virt...
pkg/http_server/lib/src/virtual_directory.dart:81:
request.response.redirect(Uri.parse('${request.uri}/'),
On 2014/01/06 13:18:08, Søren Gjesse wrote:
> According to RFC 2616 section 14.30 the redirect location should be an
absolute
> URI.

Done.

[Søren Gjesse, 2014-01-09 10:19:47]

https://codereview.chromium.org/119453005/diff/60001/pkg/http_server/lib/src/...
File pkg/http_server/lib/src/virtual_directory.dart (right):

https://codereview.chromium.org/119453005/diff/60001/pkg/http_server/lib/src/...
pkg/http_server/lib/src/virtual_directory.dart:81:
request.response.redirect(Uri.parse('${request.requestedUri}/'),
As requestedUri was just added to dart:io we need to update the SDK dependency
to 1.2, unless we get it merged into 1.1.

Perhaps copy the implementation here and remove it when 1.2 is out.

[Anders Johnsen, 2014-01-09 10:24:08]

PTAL

https://codereview.chromium.org/119453005/diff/60001/pkg/http_server/lib/src/...
File pkg/http_server/lib/src/virtual_directory.dart (right):

https://codereview.chromium.org/119453005/diff/60001/pkg/http_server/lib/src/...
pkg/http_server/lib/src/virtual_directory.dart:81:
request.response.redirect(Uri.parse('${request.requestedUri}/'),
On 2014/01/09 10:19:47, Søren Gjesse wrote:
> As requestedUri was just added to dart:io we need to update the SDK dependency
> to 1.2, unless we get it merged into 1.1.
> 
> Perhaps copy the implementation here and remove it when 1.2 is out.

Using relative Uri for now, added TODO.

[Søren Gjesse, 2014-01-09 10:25:28]

lgtm

[Anders Johnsen, 2014-01-09 10:27:03]

Committed patchset #3 manually as r31651 (presubmit successful).