Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: pkg/http_server/test/virtual_directory_test.dart

Issue 119453005: Make VirtualDirectory redirect if the directory-path does not end with a tailing slash. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Using relative Uri for now. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/http_server/test/utils.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/http_server/test/virtual_directory_test.dart
diff --git a/pkg/http_server/test/virtual_directory_test.dart b/pkg/http_server/test/virtual_directory_test.dart
index a0e9a0e877993dd8bd13cbdde11ddc712e38fda2..eff53cccaa3ead1b0e299c287ff01b1936e12efd 100644
--- a/pkg/http_server/test/virtual_directory_test.dart
+++ b/pkg/http_server/test/virtual_directory_test.dart
@@ -189,6 +189,19 @@ void main() {
});
testVirtualDir('index-2', (dir) {
+ new Directory('${dir.path}/dir').createSync();
+ var virDir = new VirtualDirectory(dir.path);
+ virDir.allowDirectoryListing = true;
+ virDir.directoryHandler = (dir2, request) {
+ fail('not expected');
+ };
+ return getStatusCodeForVirtDir(virDir, '/dir', followRedirects: false)
+ .then((result) {
+ expect(result, 301);
+ });
+ });
+
+ testVirtualDir('index-3', (dir) {
new File('${dir.path}/dir/index.html')
..createSync(recursive: true)
..writeAsStringSync('index file');
@@ -199,12 +212,28 @@ void main() {
var indexUri = new Uri.file(dir2.path).resolve('index.html');
return virDir.serveFile(new File(indexUri.toFilePath()), request);
};
-
return getAsString(virDir, '/dir')
.then((result) {
expect(result, 'index file');
});
});
+
+ testVirtualDir('index-4', (dir) {
+ new File('${dir.path}/dir/index.html')
+ ..createSync(recursive: true)
+ ..writeAsStringSync('index file');
+ var virDir = new VirtualDirectory(dir.path);
+ virDir.allowDirectoryListing = true;
+ virDir.directoryHandler = (dir2, request) {
+ // Redirect directory-requests to index.html files.
+ var indexUri = new Uri.file(dir2.path).resolve('index.html');
+ virDir.serveFile(new File(indexUri.toFilePath()), request);
+ };
+ return getAsString(virDir, '/dir/')
+ .then((result) {
+ expect(result, 'index file');
+ });
+ });
});
});
« no previous file with comments | « pkg/http_server/test/utils.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698