Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1193033003: Use List instead of Set for library sources. (Closed)

Created:
5 years, 6 months ago by scheglov
Modified:
5 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use List instead of Set for library sources. This slightly improves WorkOrder.moveNext tag performance. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/5cf6c26ecd3ddb2a04eb92543a227a7c3f5d6e0d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M pkg/analyzer/lib/src/task/dart.dart View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 6 months ago (2015-06-22 18:47:49 UTC) #1
Brian Wilkerson
LGTM
5 years, 6 months ago (2015-06-22 18:59:19 UTC) #2
scheglov
5 years, 6 months ago (2015-06-22 19:00:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5cf6c26ecd3ddb2a04eb92543a227a7c3f5d6e0d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698