Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Unified Diff: pkg/analyzer/lib/src/task/dart.dart

Issue 1193033003: Use List instead of Set for library sources. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/task/dart.dart
diff --git a/pkg/analyzer/lib/src/task/dart.dart b/pkg/analyzer/lib/src/task/dart.dart
index 03fbb2e7c0d7d1d705f907d6b696f3b40a2658d9..c7c80a314e18b48edf4cc9e484863ac8d8f3dd42 100644
--- a/pkg/analyzer/lib/src/task/dart.dart
+++ b/pkg/analyzer/lib/src/task/dart.dart
@@ -3537,7 +3537,7 @@ enum _SourceClosureKind { IMPORT, EXPORT, IMPORT_EXPORT }
class _SourceClosureTaskInputBuilder implements TaskInputBuilder<List<Source>> {
final _SourceClosureKind kind;
final Set<LibraryElement> _libraries = new HashSet<LibraryElement>();
- final Set<Source> _newSources = new HashSet<Source>();
+ final List<Source> _newSources = <Source>[];
Source currentTarget;
@@ -3585,8 +3585,7 @@ class _SourceClosureTaskInputBuilder implements TaskInputBuilder<List<Source>> {
if (_newSources.isEmpty) {
return false;
}
- currentTarget = _newSources.first;
- _newSources.remove(currentTarget);
+ currentTarget = _newSources.removeLast();
return true;
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698