Issue 11926022: Add mips skeleton sources.

Issue 11926022: Add mips skeleton sources. (Closed)

Created:
7 years, 11 months ago by regis

Modified:
7 years, 11 months ago

Reviewers:
srdjan, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add mips skeleton sources. Committed: https://code.google.com/p/dart/source/detail?r=17320

Patch Set 2 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2527 lines, -0 lines)			Patch
A	runtime/vm/assembler_macros_mips.h	View		1 chunk	+54 lines, -0 lines	0 comments	Download
A	runtime/vm/assembler_macros_mips.cc	View		1 chunk	+34 lines, -0 lines	0 comments	Download
A	runtime/vm/assembler_mips.h	View		1 chunk	+183 lines, -0 lines	0 comments	Download
A	runtime/vm/assembler_mips.cc	View		1 chunk	+19 lines, -0 lines	0 comments	Download
A	runtime/vm/code_patcher_mips.cc	View		1 chunk	+54 lines, -0 lines	0 comments	Download
A	runtime/vm/constants_mips.h	View	1	1 chunk	+108 lines, -0 lines	0 comments	Download
A	runtime/vm/cpu_mips.cc	View	1	1 chunk	+29 lines, -0 lines	0 comments	Download
A	runtime/vm/debugger_mips.cc	View	1	1 chunk	+36 lines, -0 lines	0 comments	Download
A	runtime/vm/disassembler_mips.cc	View		1 chunk	+30 lines, -0 lines	0 comments	Download
A	runtime/vm/flow_graph_compiler_mips.cc	View		1 chunk	+368 lines, -0 lines	0 comments	Download
A	runtime/vm/instructions_mips.h	View		1 chunk	+99 lines, -0 lines	0 comments	Download
A	runtime/vm/instructions_mips.cc	View		1 chunk	+44 lines, -0 lines	0 comments	Download
A	runtime/vm/intermediate_language_mips.cc	View		1 chunk	+725 lines, -0 lines	0 comments	Download
A	runtime/vm/intrinsifier_mips.cc	View		1 chunk	+408 lines, -0 lines	0 comments	Download
A	runtime/vm/object_mips_test.cc	View	1	1 chunk	+40 lines, -0 lines	0 comments	Download
A	runtime/vm/runtime_entry_mips.cc	View	1	1 chunk	+18 lines, -0 lines	0 comments	Download
A	runtime/vm/stack_frame_mips.cc	View	1	1 chunk	+47 lines, -0 lines	0 comments	Download
A	runtime/vm/stub_code_mips.cc	View		1 chunk	+231 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM https://codereview.chromium.org/11926022/diff/1/runtime/vm/constants_mips.h File runtime/vm/constants_mips.h (right): https://codereview.chromium.org/11926022/diff/1/runtime/vm/constants_mips.h#newcode94 runtime/vm/constants_mips.h:94: const Register TMP = AT; // No scratch ...

7 years, 11 months ago (2013-01-18 19:48:41 UTC) #2

regis

7 years, 11 months ago (2013-01-18 21:45:42 UTC) #3

Message was sent while issue was closed.

Thanks

https://codereview.chromium.org/11926022/diff/1/runtime/vm/constants_mips.h
File runtime/vm/constants_mips.h (right):

https://codereview.chromium.org/11926022/diff/1/runtime/vm/constants_mips.h#n...
runtime/vm/constants_mips.h:94: const Register TMP = AT;  // No scratch register
used by assembler.
On 2013/01/18 19:48:41, srdjan wrote:
> Wrong comment: there is a scratch register.

Removed comment.

Expand Messages | Collapse Messages