Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 119213002: Use parallel move resolver for optimized try-catch. (Closed)

Created:
7 years ago by Florian Schneider
Modified:
7 years ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org, turnidge
Visibility:
Public.

Description

Use parallel move resolver for optimized try-catch. This CL has no change in functionality and is purely clean up and refactoring. Instead of manually generating the moves at throwing instructions in try-catch, construct a parallel move and use the resolver to emit the native code. This eliminates a lot of duplicated code from all platforms. It will also allow to re-use stack space that is currently allocated separately for each individual try-catch in a function. I added a few more unrelated minor changes in various parts of the VM * Simpilify guard code generation * Resolve refactoring TODO in deoptimization * Improve names R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=31326

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -326 lines) Patch
M runtime/vm/deferred_objects.h View 7 chunks +7 lines, -6 lines 0 comments Download
M runtime/vm/deferred_objects.cc View 5 chunks +6 lines, -11 lines 0 comments Download
M runtime/vm/deopt_instructions.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M runtime/vm/flow_graph_compiler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 2 chunks +44 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 1 chunk +0 lines, -68 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 1 chunk +0 lines, -69 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 1 chunk +0 lines, -68 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 chunk +0 lines, -68 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 3 chunks +1 line, -6 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 3 chunks +1 line, -7 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 3 chunks +1 line, -6 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 3 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Florian Schneider
7 years ago (2013-12-19 13:16:48 UTC) #1
Florian Schneider
Corrected reviewer email.
7 years ago (2013-12-19 13:18:02 UTC) #2
Cutch
lgtm
7 years ago (2013-12-19 14:46:04 UTC) #3
Florian Schneider
7 years ago (2013-12-20 09:41:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r31326 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698