Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Side by Side Diff: runtime/vm/intermediate_language_ia32.cc

Issue 119213002: Use parallel move resolver for optimized try-catch. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | runtime/vm/intermediate_language_mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32.
6 #if defined(TARGET_ARCH_IA32) 6 #if defined(TARGET_ARCH_IA32)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 1271 matching lines...) Expand 10 before | Expand all | Expand 10 after
1282 Register field_reg = needs_field_temp_reg ? 1282 Register field_reg = needs_field_temp_reg ?
1283 locs()->temp(locs()->temp_count() - 1).reg() : kNoRegister; 1283 locs()->temp(locs()->temp_count() - 1).reg() : kNoRegister;
1284 1284
1285 Label ok, fail_label; 1285 Label ok, fail_label;
1286 1286
1287 Label* deopt = compiler->is_optimizing() ? 1287 Label* deopt = compiler->is_optimizing() ?
1288 compiler->AddDeoptStub(deopt_id(), kDeoptGuardField) : NULL; 1288 compiler->AddDeoptStub(deopt_id(), kDeoptGuardField) : NULL;
1289 1289
1290 Label* fail = (deopt != NULL) ? deopt : &fail_label; 1290 Label* fail = (deopt != NULL) ? deopt : &fail_label;
1291 1291
1292 const bool ok_is_fall_through = (deopt != NULL);
1293
1294 if (!compiler->is_optimizing() || (field_cid == kIllegalCid)) { 1292 if (!compiler->is_optimizing() || (field_cid == kIllegalCid)) {
1295 if (!compiler->is_optimizing() && (field_reg == kNoRegister)) { 1293 if (!compiler->is_optimizing() && (field_reg == kNoRegister)) {
1296 // Currently we can't have different location summaries for optimized 1294 // Currently we can't have different location summaries for optimized
1297 // and non-optimized code. So instead we manually pick up a register 1295 // and non-optimized code. So instead we manually pick up a register
1298 // that is known to be free because we know how non-optimizing compiler 1296 // that is known to be free because we know how non-optimizing compiler
1299 // allocates registers. 1297 // allocates registers.
1300 field_reg = EBX; 1298 field_reg = EBX;
1301 ASSERT((field_reg != value_reg) && (field_reg != value_cid_reg)); 1299 ASSERT((field_reg != value_reg) && (field_reg != value_cid_reg));
1302 } 1300 }
1303 1301
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
1484 __ movl(value_cid_reg, 1482 __ movl(value_cid_reg,
1485 FieldAddress(value_reg, TypedData::length_offset())); 1483 FieldAddress(value_reg, TypedData::length_offset()));
1486 __ movl(field_length_operand, value_cid_reg); 1484 __ movl(field_length_operand, value_cid_reg);
1487 } else { 1485 } else {
1488 __ movl(field_length_operand, 1486 __ movl(field_length_operand,
1489 Immediate(Smi::RawValue(Field::kNoFixedLength))); 1487 Immediate(Smi::RawValue(Field::kNoFixedLength)));
1490 } 1488 }
1491 } 1489 }
1492 } 1490 }
1493 1491
1494 if (!ok_is_fall_through) {
1495 __ jmp(&ok);
1496 }
1497
1498 if (deopt == NULL) { 1492 if (deopt == NULL) {
1499 ASSERT(!compiler->is_optimizing()); 1493 ASSERT(!compiler->is_optimizing());
1494 __ jmp(&ok);
1500 __ Bind(fail); 1495 __ Bind(fail);
1501 1496
1502 __ cmpl(FieldAddress(field_reg, Field::guarded_cid_offset()), 1497 __ cmpl(FieldAddress(field_reg, Field::guarded_cid_offset()),
1503 Immediate(kDynamicCid)); 1498 Immediate(kDynamicCid));
1504 __ j(EQUAL, &ok); 1499 __ j(EQUAL, &ok);
1505 1500
1506 __ pushl(field_reg); 1501 __ pushl(field_reg);
1507 __ pushl(value_reg); 1502 __ pushl(value_reg);
1508 __ CallRuntime(kUpdateFieldCidRuntimeEntry, 2); 1503 __ CallRuntime(kUpdateFieldCidRuntimeEntry, 2);
1509 __ Drop(2); // Drop the field and the value. 1504 __ Drop(2); // Drop the field and the value.
1510 } 1505 }
1511 } else { 1506 } else {
1512 ASSERT(compiler->is_optimizing()); 1507 ASSERT(compiler->is_optimizing());
1513 ASSERT(deopt != NULL); 1508 ASSERT(deopt != NULL);
1514 ASSERT(ok_is_fall_through);
1515 // Field guard class has been initialized and is known. 1509 // Field guard class has been initialized and is known.
1516 if (field_reg != kNoRegister) { 1510 if (field_reg != kNoRegister) {
1517 __ LoadObject(field_reg, Field::ZoneHandle(field().raw())); 1511 __ LoadObject(field_reg, Field::ZoneHandle(field().raw()));
1518 } 1512 }
1519 1513
1520 if (value_cid == kDynamicCid) { 1514 if (value_cid == kDynamicCid) {
1521 // Value's class id is not known. 1515 // Value's class id is not known.
1522 __ testl(value_reg, Immediate(kSmiTagMask)); 1516 __ testl(value_reg, Immediate(kSmiTagMask));
1523 1517
1524 if (field_cid != kSmiCid) { 1518 if (field_cid != kSmiCid) {
(...skipping 3677 matching lines...) Expand 10 before | Expand all | Expand 10 after
5202 PcDescriptors::kOther, 5196 PcDescriptors::kOther,
5203 locs()); 5197 locs());
5204 __ Drop(2); // Discard type arguments and receiver. 5198 __ Drop(2); // Discard type arguments and receiver.
5205 } 5199 }
5206 5200
5207 } // namespace dart 5201 } // namespace dart
5208 5202
5209 #undef __ 5203 #undef __
5210 5204
5211 #endif // defined TARGET_ARCH_IA32 5205 #endif // defined TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | runtime/vm/intermediate_language_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698