Port "Add flag to disable lazy compilation of invocation dispatchers."

Port "Add flag to disable lazy compilation of invocation dispatchers."

Fix InvokeNoSuchMethodDispatcher to propagate with a rethrow instead of a throw.

Fix unit test checking raw stack frames.

R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/66194d4fc19db8a129f97bfe74ce87ba312048f7

[rmacnak, 2015-06-16 21:14:25]

rmacnak@google.com changed reviewers:
+ fschneider@google.com, srdjan@google.com

[Florian Schneider, 2015-06-17 08:01:34]

Is there maybe a file missing? I don't see the code corresponding to fixing the
error propagation (rethrow vs. throw) that you mentioned in the CL description.

https://codereview.chromium.org/1191813002/diff/40001/runtime/vm/stub_code_ar...
File runtime/vm/stub_code_arm.cc (right):

https://codereview.chromium.org/1191813002/diff/40001/runtime/vm/stub_code_ar...
runtime/vm/stub_code_arm.cc:590: __ Pop(R0);
I would use 

__ Drop(4);
__ Pop(R0);

for smaller code size.

https://codereview.chromium.org/1191813002/diff/40001/runtime/vm/stub_code_ia...
File runtime/vm/stub_code_ia32.cc (right):

https://codereview.chromium.org/1191813002/diff/40001/runtime/vm/stub_code_ia...
runtime/vm/stub_code_ia32.cc:532: __ popl(EAX);
__ Drop(4);
__ popl(EAX);

https://codereview.chromium.org/1191813002/diff/40001/runtime/vm/stub_code_x6...
File runtime/vm/stub_code_x64.cc (right):

https://codereview.chromium.org/1191813002/diff/40001/runtime/vm/stub_code_x6...
runtime/vm/stub_code_x64.cc:554: __ popq(RAX);
__ Drop(4);
__ popq(RAX);

[rmacnak, 2015-06-17 17:42:20]

https://codereview.chromium.org/1191813002/diff/40001/runtime/vm/stub_code_ar...
File runtime/vm/stub_code_arm.cc (right):

https://codereview.chromium.org/1191813002/diff/40001/runtime/vm/stub_code_ar...
runtime/vm/stub_code_arm.cc:590: __ Pop(R0);
On 2015/06/17 08:01:34, Florian Schneider wrote:
> I would use 
> 
> __ Drop(4);
> __ Pop(R0);
> 
> for smaller code size.

Done.

https://codereview.chromium.org/1191813002/diff/40001/runtime/vm/stub_code_ia...
File runtime/vm/stub_code_ia32.cc (right):

https://codereview.chromium.org/1191813002/diff/40001/runtime/vm/stub_code_ia...
runtime/vm/stub_code_ia32.cc:532: __ popl(EAX);
On 2015/06/17 08:01:34, Florian Schneider wrote:
> __ Drop(4);
> __ popl(EAX);

Done.

https://codereview.chromium.org/1191813002/diff/40001/runtime/vm/stub_code_x6...
File runtime/vm/stub_code_x64.cc (right):

https://codereview.chromium.org/1191813002/diff/40001/runtime/vm/stub_code_x6...
runtime/vm/stub_code_x64.cc:554: __ popq(RAX);
On 2015/06/17 08:01:34, Florian Schneider wrote:
> __ Drop(4);
> __ popq(RAX);

Done.

[rmacnak, 2015-06-17 17:42:44]

On 2015/06/17 08:01:34, Florian Schneider wrote:
> Is there maybe a file missing? I don't see the code corresponding to fixing
the
> error propagation (rethrow vs. throw) that you mentioned in the CL
description.

The fix is to remove those changes from the original CL. The way that
exceptions.cc pieces together a stack has  improved since the precompilation
fork.

[Florian Schneider, 2015-06-18 07:13:01]

LGTM.

[Florian Schneider, 2015-06-18 14:13:50]

On 2015/06/18 07:13:01, Florian Schneider wrote:
> LGTM.

Note that method extraction and field invocation can be handled in the same way.
It's fine to do this in a follow-up CL if you prefer.

[rmacnak, 2015-06-18 17:05:51]

On 2015/06/18 14:13:50, Florian Schneider wrote:
> On 2015/06/18 07:13:01, Florian Schneider wrote:
> > LGTM.
> 
> Note that method extraction and field invocation can be handled in the same
way.
> It's fine to do this in a follow-up CL if you prefer.

Small steps :)

[rmacnak, 2015-06-18 17:23:47]

Committed patchset #4 (id:60001) manually as
66194d4fc19db8a129f97bfe74ce87ba312048f7 (presubmit successful).