Port "Add flag to disable lazy compilation of invocation dispatchers."

runtime/vm/stack_frame_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
 #include "vm/dart_api_impl.h"
 #include "vm/dart_entry.h"
 #include "vm/resolver.h"
 #include "vm/stack_frame.h"
 #include "vm/unit_test.h"
 #include "vm/verifier.h"
 #include "vm/zone.h"
 
 namespace dart {
 
+DECLARE_FLAG(bool, lazy_dispatchers);
+
 // Unit test for empty stack frame iteration.
 TEST_CASE(EmptyStackFrameIteration) {
   StackFrameIterator iterator(StackFrameIterator::kValidateFrames);
   EXPECT(!iterator.HasNextFrame());
   EXPECT(iterator.NextFrame() == NULL);
   VerifyPointersVisitor::VerifyPointers();
 }
 
 
 // Unit test for empty dart stack frame iteration.
@@ skipping 210 matching lines @@
   Dart_Handle lib = TestCase::LoadTestScript(
       kScriptChars,
       reinterpret_cast<Dart_NativeEntryResolver>(native_lookup));
   Dart_Handle cls = Dart_GetClass(lib, NewString("StackFrameTest"));
   EXPECT_VALID(Dart_Invoke(cls, NewString("testMain"), 0, NULL));
 }
 
 
 // Unit test case to verify stack frame iteration.
 TEST_CASE(ValidateNoSuchMethodStackFrameIteration) {
-  const char* kScriptChars =
+  const char* kScriptChars;
+  // The true stack depends on which strategy we are using for noSuchMethod. The
+  // stacktrace as seen by Dart is the same either way because dispatcher
+  // methods are marked invisible.
+  if (FLAG_lazy_dispatchers) {
+    kScriptChars =
       "class StackFrame {"
       "  static equals(var obj1, var obj2) native \"StackFrame_equals\";"
       "  static int frameCount() native \"StackFrame_frameCount\";"
       "  static int dartFrameCount() native \"StackFrame_dartFrameCount\";"
       "  static validateFrame(int index,"
       "                       String name) native \"StackFrame_validateFrame\";"
       "} "
       "class StackFrame2Test {"
       "  StackFrame2Test() {}"
       "  noSuchMethod(Invocation im) {"
@@ skipping 11 matching lines @@
       "    StackFrame.validateFrame(1, \"StackFrame2Test_noSuchMethod\");"
       "    StackFrame.validateFrame(2, \"StackFrame2Test_foo\");"
       "    StackFrame.validateFrame(3, \"StackFrame2Test_testMain\");"
       "    return 5;"
       "  }"
       "  static testMain() {"
       "    var obj = new StackFrame2Test();"
       "    StackFrame.equals(5, obj.foo(101, 202));"
       "  }"
       "}";
+  } else {
+    kScriptChars =
+      "class StackFrame {"
+      "  static equals(var obj1, var obj2) native \"StackFrame_equals\";"
+      "  static int frameCount() native \"StackFrame_frameCount\";"
+      "  static int dartFrameCount() native \"StackFrame_dartFrameCount\";"
+      "  static validateFrame(int index,"
+      "                       String name) native \"StackFrame_validateFrame\";"
+      "} "
+      "class StackFrame2Test {"
+      "  StackFrame2Test() {}"
+      "  noSuchMethod(Invocation im) {"
+      "    /* We should have 8 general frames and 3 dart frames as follows:"
+      "     * exit frame"
+      "     * dart frame corresponding to StackFrame.frameCount"
+      "     * dart frame corresponding to StackFrame2Test.noSuchMethod"
+      "     * entry frame"
+      "     * exit frame (call to runtime InvokeNoSuchMethodDispatcher)"
+      "     * IC stub"
+      "     * dart frame corresponding to StackFrame2Test.testMain"
+      "     * entry frame"
+      "     */"
+      "    StackFrame.equals(8, StackFrame.frameCount());"
+      "    StackFrame.equals(3, StackFrame.dartFrameCount());"
+      "    StackFrame.validateFrame(0, \"StackFrame_validateFrame\");"
+      "    StackFrame.validateFrame(1, \"StackFrame2Test_noSuchMethod\");"
+      "    StackFrame.validateFrame(2, \"StackFrame2Test_testMain\");"
+      "    return 5;"
+      "  }"
+      "  static testMain() {"
+      "    var obj = new StackFrame2Test();"
+      "    StackFrame.equals(5, obj.foo(101, 202));"
+      "  }"
+      "}";
+  }
   Dart_Handle lib = TestCase::LoadTestScript(
       kScriptChars,
       reinterpret_cast<Dart_NativeEntryResolver>(native_lookup));
   Dart_Handle cls = Dart_GetClass(lib, NewString("StackFrame2Test"));
   EXPECT_VALID(Dart_Invoke(cls, NewString("testMain"), 0, NULL));
 }
 
 }  // namespace dart