Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 1190973003: Fix crash with --noopt and no_snapshot: initialize megamorphic cache table before first code is run. (Closed)

Created:
5 years, 6 months ago by srdjan
Modified:
5 years, 6 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix crash with --noopt and no_snapshot: initialize megamorphic cache table before first code is run. BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/a2c1601c0a7033b261456d291625a68f10c516a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M runtime/vm/dart.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
srdjan
5 years, 6 months ago (2015-06-17 16:43:47 UTC) #2
siva
lgtm
5 years, 6 months ago (2015-06-17 16:45:04 UTC) #3
srdjan
5 years, 6 months ago (2015-06-17 17:09:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a2c1601c0a7033b261456d291625a68f10c516a9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698