Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1190473004: Add flag polymorphic_with_deopt (default true) and handle case when false: use megamorphic instead … (Closed)

Created:
5 years, 6 months ago by srdjan
Modified:
5 years, 6 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add flag polymorphic_with_deopt (default true) and handle case when false: use megamorphic instead of deopt. Tested, it will be used with --noopt BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/247805b8e537836832a420d5d20a4d8ed7a32a0c

Patch Set 1 #

Patch Set 2 : r #

Total comments: 4

Patch Set 3 : g #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -158 lines) Patch
M runtime/vm/flow_graph_compiler.h View 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 1 2 2 chunks +39 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 2 chunks +26 lines, -3 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 2 chunks +1 line, -31 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
srdjan
5 years, 6 months ago (2015-06-16 20:20:44 UTC) #2
rmacnak
LGTM with comment clarifications https://codereview.chromium.org/1190473004/diff/20001/runtime/vm/flow_graph_compiler.cc File runtime/vm/flow_graph_compiler.cc (right): https://codereview.chromium.org/1190473004/diff/20001/runtime/vm/flow_graph_compiler.cc#newcode41 runtime/vm/flow_graph_compiler.cc:41: "deoptimization or megamorphic call"); causes ...
5 years, 6 months ago (2015-06-16 20:47:34 UTC) #3
srdjan
https://codereview.chromium.org/1190473004/diff/20001/runtime/vm/flow_graph_compiler.cc File runtime/vm/flow_graph_compiler.cc (right): https://codereview.chromium.org/1190473004/diff/20001/runtime/vm/flow_graph_compiler.cc#newcode41 runtime/vm/flow_graph_compiler.cc:41: "deoptimization or megamorphic call"); On 2015/06/16 20:47:33, rmacnak wrote: ...
5 years, 6 months ago (2015-06-16 21:06:12 UTC) #4
srdjan
5 years, 6 months ago (2015-06-16 21:11:20 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
247805b8e537836832a420d5d20a4d8ed7a32a0c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698