Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: runtime/vm/flow_graph_compiler.cc

Issue 1190473004: Add flag polymorphic_with_deopt (default true) and handle case when false: use megamorphic instead … (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: g Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler.h ('k') | runtime/vm/intermediate_language.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler.cc
diff --git a/runtime/vm/flow_graph_compiler.cc b/runtime/vm/flow_graph_compiler.cc
index 169c8576e190ac0a1f4cb23b920d55e58a637ba3..3433de04a0cc693ff77918b29c3c2093968b0ca5 100644
--- a/runtime/vm/flow_graph_compiler.cc
+++ b/runtime/vm/flow_graph_compiler.cc
@@ -30,15 +30,18 @@ namespace dart {
DEFINE_FLAG(bool, always_megamorphic_calls, false,
"Instance call always as megamorphic.");
-DEFINE_FLAG(bool, trace_inlining_intervals, false,
- "Inlining interval diagnostics");
DEFINE_FLAG(bool, enable_simd_inline, true,
"Enable inlining of SIMD related method calls.");
DEFINE_FLAG(int, min_optimization_counter_threshold, 5000,
"The minimum invocation count for a function.");
DEFINE_FLAG(int, optimization_counter_scale, 2000,
"The scale of invocation count, by size of the function.");
+DEFINE_FLAG(bool, polymorphic_with_deopt, true,
+ "Polymorphic calls can be generated so that failure either causes "
+ "deoptimization or falls through to a megamorphic call");
DEFINE_FLAG(bool, source_lines, false, "Emit source line as assembly comment.");
+DEFINE_FLAG(bool, trace_inlining_intervals, false,
+ "Inlining interval diagnostics");
DEFINE_FLAG(bool, use_megamorphic_stub, true, "Out of line megamorphic lookup");
DECLARE_FLAG(bool, code_comments);
@@ -1669,6 +1672,40 @@ RawArray* FlowGraphCompiler::InliningIdToFunction() const {
}
+void FlowGraphCompiler::EmitPolymorphicInstanceCall(
+ const ICData& ic_data,
+ intptr_t argument_count,
+ const Array& argument_names,
+ intptr_t deopt_id,
+ intptr_t token_pos,
+ LocationSummary* locs) {
+ if (FLAG_polymorphic_with_deopt) {
+ Label* deopt = AddDeoptStub(deopt_id,
+ ICData::kDeoptPolymorphicInstanceCallTestFail);
+ Label ok;
+ EmitTestAndCall(ic_data, argument_count, argument_names,
+ deopt, // No cid match.
+ &ok, // Found cid.
+ deopt_id, token_pos, locs);
+ assembler()->Bind(&ok);
+ } else {
+ // Instead of deoptimizing, do a megamorphic call when no matching
+ // cid found.
+ Label megamorphic, ok;
+ EmitTestAndCall(ic_data, argument_count, argument_names,
+ &megamorphic, // No cid match.
+ &ok, // Found cid.
+ deopt_id, token_pos, locs);
+ // Fall through if last test is match.
+ assembler()->Jump(&ok);
+ assembler()->Bind(&megamorphic);
+ EmitMegamorphicInstanceCall(ic_data, argument_count, deopt_id,
+ token_pos, locs);
+ assembler()->Bind(&ok);
+ }
+}
+
+
#if defined(DEBUG)
void FlowGraphCompiler::FrameStateUpdateWith(Instruction* instr) {
ASSERT(!is_optimizing());
« no previous file with comments | « runtime/vm/flow_graph_compiler.h ('k') | runtime/vm/intermediate_language.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698