Issue 1189873005: dart2js: Support frequency based metadata indices in new emitter.

Issue 1189873005: dart2js: Support frequency based metadata indices in new emitter. (Closed)

Created:
5 years, 6 months ago by herhut

Modified:
5 years, 6 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

dart2js: Support frequency based metadata indices in new emitter. R=floitsch@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/fac25eb5411bad0b6b139be6a43cdfc57ed9c3d2

Patch Set 2 : Comments addressed #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+100 lines, -34 lines)			Patch
M	pkg/compiler/lib/src/js_emitter/metadata_collector.dart	View		3 chunks	+27 lines, -3 lines	0 comments	Download
M	pkg/compiler/lib/src/js_emitter/model.dart	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart	View	1	5 chunks	+69 lines, -28 lines	0 comments	Download
M	pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://codereview.chromium.org/1189873005/diff/1/pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart File pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart (right): https://codereview.chromium.org/1189873005/diff/1/pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart#newcode204 pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:204: /// Unparses the given [value]. Update comment.

5 years, 6 months ago (2015-06-17 14:32:27 UTC) #2

herhut

https://codereview.chromium.org/1189873005/diff/1/pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart File pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart (right): https://codereview.chromium.org/1189873005/diff/1/pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart#newcode204 pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:204: /// Unparses the given [value]. On 2015/06/17 14:32:27, floitsch ...

5 years, 6 months ago (2015-06-18 07:40:34 UTC) #3

herhut

5 years, 6 months ago (2015-06-18 07:42:31 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
fac25eb5411bad0b6b139be6a43cdfc57ed9c3d2 (presubmit successful).

Expand Messages | Collapse Messages