Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1316)

Unified Diff: pkg/compiler/lib/src/js_emitter/metadata_collector.dart

Issue 1189873005: dart2js: Support frequency based metadata indices in new emitter. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Comments addressed Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_emitter/model.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_emitter/metadata_collector.dart
diff --git a/pkg/compiler/lib/src/js_emitter/metadata_collector.dart b/pkg/compiler/lib/src/js_emitter/metadata_collector.dart
index a2eeb986d358677f708289955645f8508b4a7ba2..68ec03dcfc3492f195c7841654fd80f8ff3be139 100644
--- a/pkg/compiler/lib/src/js_emitter/metadata_collector.dart
+++ b/pkg/compiler/lib/src/js_emitter/metadata_collector.dart
@@ -107,7 +107,7 @@ class _MetadataList extends jsAst.DeferredExpression {
int get precedenceLevel => js_precedence.PRIMARY;
}
-class MetadataCollector {
+class MetadataCollector implements TokenFinalizer {
final Compiler _compiler;
final Emitter _emitter;
@@ -297,11 +297,13 @@ class MetadataCollector {
});
}
- void countTokensInProgram(jsAst.Program program) {
+ @override
+ void countTokensInAst(jsAst.Node ast) {
TokenCounter visitor = new TokenCounter();
- visitor.countTokens(program);
+ visitor.countTokens(ast);
}
+ @override
void finalizeTokens() {
bool checkTokensInTypes(OutputUnit outputUnit, entries) {
UnBoundDebugger debugger = new UnBoundDebugger(outputUnit);
@@ -358,8 +360,30 @@ class MetadataCollector {
}
}
+/// Interface for ast nodes that encapsulate an ast that needs to be
+/// traversed when counting tokens.
+///
+/// TODO(herhut): Find a shared place once namer also uses tokens.
+abstract class AstContainer implements jsAst.Node {
+ jsAst.Node get ast;
+}
+
+abstract class TokenFinalizer {
+ void countTokensInAst(jsAst.Node ast);
+ void finalizeTokens();
+}
+
class TokenCounter extends jsAst.BaseVisitor {
@override
+ visitNode(jsAst.Node node) {
+ if (node is AstContainer) {
+ node.ast.accept(this);
+ } else {
+ super.visitNode(node);
+ }
+ }
+
+ @override
visitDeferredNumber(jsAst.DeferredNumber token) {
if (token is _MetadataEntry) {
token.markSeen(this);
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_emitter/model.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698