Get the most basic mixin applications working.

Get the most basic mixin applications working.

This CL builds upon the code in https://codereview.chromium.org/11970011/
so that needs to land before this can.

R=ahe@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=17268

[kasperl, 2013-01-17 14:10:26]

Gilad: Please take a look at the test case. The rest is still very much work in
progress.

[gbracha, 2013-01-17 18:24:20]

See comments re subtyping

https://codereview.chromium.org/11886097/diff/14/tests/language/mixin_test.dart
File tests/language/mixin_test.dart (right):

https://codereview.chromium.org/11886097/diff/14/tests/language/mixin_test.da...
tests/language/mixin_test.dart:33: Expect.isFalse(c is M2);
So per the current spec,  c is M1 should be true. Likewise, d is M1, d is M2, e
is M1 and e is M2 (but not c is M2 of course). See my e-mail.

[kasperl, 2013-01-18 06:21:10]

https://codereview.chromium.org/11886097/diff/14/tests/language/mixin_test.dart
File tests/language/mixin_test.dart (right):

https://codereview.chromium.org/11886097/diff/14/tests/language/mixin_test.da...
tests/language/mixin_test.dart:33: Expect.isFalse(c is M2);
On 2013/01/17 18:24:20, gbracha wrote:
> So per the current spec,  c is M1 should be true. Likewise, d is M1, d is M2,
e
> is M1 and e is M2 (but not c is M2 of course). See my e-mail.

Thanks, Gilad. Done.

[ahe, 2013-01-18 12:40:12]

LGTM!

You should probably add a test of having a cyclic mixin hierarchy.

https://codereview.chromium.org/11886097/diff/18001/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/11886097/diff/18001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:2826: new
SourceString("${superName}_${mixinName}"),
I'm really concerned about this. We did something similar for constructors and
operators, and it has been a nightmare to get rid of it, and deal with the weird
situations that occur when a user defines a name that conflicts with the
generated name.

It would be much better if you could generate a synthetic name that isn't a
valid Dart identifier. In fact, if you always used the empty string, it would be
clear that you cannot use this identifier for looking it up elsewhere in the
system.

https://codereview.chromium.org/11886097/diff/18001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:3013:
visitNodeList(node.interfaces);
Generally, I don't like calling the visitor methods directly. I removes dynamic
dispatch.

https://codereview.chromium.org/11886097/diff/18001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:3018:
visitNodeList(node.mixins);
Ditto.

https://codereview.chromium.org/11886097/diff/18001/tests/language/mixin_fiel...
File tests/language/mixin_field_test.dart (right):

https://codereview.chromium.org/11886097/diff/18001/tests/language/mixin_fiel...
tests/language/mixin_field_test.dart:41: Expect.throws(() => c.baz, (error) =>
error is NoSuchMethodError);
You could create a help function for: (error) => error is NoSuchMethodError