Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11885031: Adding support checks for ApplicationCache. (Closed)

Created:
7 years, 11 months ago by blois
Modified:
7 years, 11 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Adding support checks for ApplicationCache. Also fixed it to work on Opera. BUG= Committed: https://code.google.com/p/dart/source/detail?r=17101

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -7 lines) Patch
M sdk/lib/_internal/compiler/implementation/lib/native_helper.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 2 chunks +8 lines, -0 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 2 chunks +8 lines, -0 lines 0 comments Download
M sdk/lib/html/html_common/metadata.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/html/cache_test.dart View 1 chunk +19 lines, -5 lines 0 comments Download
M tests/html/html.status View 1 2 chunks +1 line, -2 lines 0 comments Download
M tools/dom/scripts/generator.py View 1 1 chunk +7 lines, -0 lines 2 comments Download
M tools/dom/scripts/systemhtml.py View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
blois
7 years, 11 months ago (2013-01-14 23:04:44 UTC) #1
Emily Fortuna
https://codereview.chromium.org/11885031/diff/1/tools/dom/scripts/generator.py File tools/dom/scripts/generator.py (right): https://codereview.chromium.org/11885031/diff/1/tools/dom/scripts/generator.py#newcode653 tools/dom/scripts/generator.py:653: 'DOMApplicationCache': _all_but_ie9_annotations, +Opera?
7 years, 11 months ago (2013-01-14 23:32:11 UTC) #2
blois
https://codereview.chromium.org/11885031/diff/1/tools/dom/scripts/generator.py File tools/dom/scripts/generator.py (right): https://codereview.chromium.org/11885031/diff/1/tools/dom/scripts/generator.py#newcode653 tools/dom/scripts/generator.py:653: 'DOMApplicationCache': _all_but_ie9_annotations, On 2013/01/14 23:32:11, Emily Fortuna wrote: > ...
7 years, 11 months ago (2013-01-15 02:05:56 UTC) #3
Emily Fortuna
https://codereview.chromium.org/11885031/diff/9/tools/dom/scripts/generator.py File tools/dom/scripts/generator.py (right): https://codereview.chromium.org/11885031/diff/9/tools/dom/scripts/generator.py#newcode662 tools/dom/scripts/generator.py:662: "@SupportedBrowser(SupportedBrowser.OPERA)", this is picky, but we should probably rename ...
7 years, 11 months ago (2013-01-15 02:23:07 UTC) #4
blois
https://codereview.chromium.org/11885031/diff/9/tools/dom/scripts/generator.py File tools/dom/scripts/generator.py (right): https://codereview.chromium.org/11885031/diff/9/tools/dom/scripts/generator.py#newcode662 tools/dom/scripts/generator.py:662: "@SupportedBrowser(SupportedBrowser.OPERA)", On 2013/01/15 02:23:07, Emily Fortuna wrote: > this ...
7 years, 11 months ago (2013-01-15 18:24:34 UTC) #5
Emily Fortuna
7 years, 11 months ago (2013-01-15 18:54:25 UTC) #6 
okay, lgtm, if you add a TODO saying to go back and add Opera in the other spots
then at a later milestone, please.

Powered by Google App Engine
This is Rietveld 408576698