Issue 11884054: Simplify the enqueuing of tests from all test suites

Issue 11884054: Simplify the enqueuing of tests from all test suites (Closed)

Created:
7 years, 11 months ago by kustermann

Modified:
7 years, 11 months ago

Reviewers:
ricow1, ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Simplify the enqueuing of tests from all test suites TBR=foo Committed: https://code.google.com/p/dart/source/detail?r=17273

Patch Set 3 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -48 lines)			Patch
M	tools/test.dart	View		2 chunks	+8 lines, -12 lines	0 comments	Download
M	tools/test-runtime.dart	View	1 2	2 chunks	+6 lines, -10 lines	0 comments	Download
M	tools/testing/dart/test_runner.dart	View	1 2	4 chunks	+22 lines, -26 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ricow1

LGTM with simplification suggestion https://codereview.chromium.org/11884054/diff/1/tools/testing/dart/test_runner.dart File tools/testing/dart/test_runner.dart (right): https://codereview.chromium.org/11884054/diff/1/tools/testing/dart/test_runner.dart#newcode1501 tools/testing/dart/test_runner.dart:1501: void testSuiteFinished() { how about ...

7 years, 11 months ago (2013-01-15 12:38:44 UTC) #2

kustermann

7 years, 11 months ago (2013-01-16 09:09:09 UTC) #3

https://codereview.chromium.org/11884054/diff/1/tools/testing/dart/test_runne...
File tools/testing/dart/test_runner.dart (right):

https://codereview.chromium.org/11884054/diff/1/tools/testing/dart/test_runne...
tools/testing/dart/test_runner.dart:1501: void testSuiteFinished() {
On 2013/01/15 12:38:44, ricow1 wrote:
> how about making this:
> void _runTests(List<TestSuite> testSuites) {
>   Iterator<TestSuite> iterator = testSuites.iterator();
>   void enqueueNextSuite() {
>     if (!iterator.hasNext()) {
>       _allTestsWereEnqueued = true;
>       _progress.allTestsKnown();
>   } else {
>     iterator.next().forEachTest(_runTest,
> 				_testCache,
> 				enqueueNextSuite);
>   }
>   enqueueNextSuite();
> }

Done.

https://codereview.chromium.org/11884054/diff/1/tools/testing/dart/test_runne...
tools/testing/dart/test_runner.dart:1512: // FIXME: For some reason we cannot
call this method on all test suites
On 2013/01/15 12:38:44, ricow1 wrote:
> could we file a bug for this

Done.

Expand Messages | Collapse Messages