Simplify the enqueuing of tests from all test suites

tools/test-runtime.dart

 #!/usr/bin/env dart
 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // TODO(ager): Get rid of this version of test.dart when we don't have
 // to worry about the special runtime checkout anymore.
 // This file is identical to test.dart with test suites in the
 // directories samples, client, compiler, and utils removed.
 
@@ skipping 54 matching lines @@
         ['Test configurations:'] : ['Test configuration:'];
     for (Map conf in configurations) {
       List settings = ['compiler', 'runtime', 'mode', 'arch']
           .mappedBy((name) => conf[name]).toList();
       if (conf['checked']) settings.add('checked');
       output_words.add(Strings.join(settings, '_'));
     }
     print(Strings.join(output_words, ' '));
   }
 
-  var configurationIterator = configurations.iterator;
-  void enqueueConfiguration(ProcessQueue queue) {
-    if (!configurationIterator.moveNext()) return;
-
-    var conf = configurationIterator.current;
+  var testSuites = new List<TestSuite>();
+  for (var conf in configurations) {
     if (selectors.containsKey('co19')) {
-      queue.addTestSuite(new Co19TestSuite(conf));
+      testSuites.add(new Co19TestSuite(conf));
     }
     if (conf['runtime'] == 'vm' && selectors.containsKey('vm')) {
       // vm tests contain both cc tests (added here) and dart tests (added in
       // [TEST_SUITE_DIRECTORIES]).
-      queue.addTestSuite(new VMTestSuite(conf));
+      testSuites.add(new VMTestSuite(conf));
     }
 
     for (final testSuiteDir in TEST_SUITE_DIRECTORIES) {
       final name = testSuiteDir.filename;
       if (selectors.containsKey(name)) {
-        queue.addTestSuite(
-            new StandardTestSuite.forDirectory(conf, testSuiteDir));
+        testSuites.add(new StandardTestSuite.forDirectory(conf, testSuiteDir));
       }
     }
   }
 
   // Start global http server that serves the entire dart repo.
   // The http server is available on localhost:9876 for any
   // test that needs to load resources from the repo over http.
   if (!listTests) {
     // Only start the server if we are running browser tests.
     var runningBrowserTests = configurations.any((config) {
       return TestUtils.isBrowserRuntime(config['runtime']);
     });
     if (runningBrowserTests) startHttpServer('127.0.0.1', 9876);
   }
 
   // Start process queue.
   new ProcessQueue(
       maxProcesses,
       progressIndicator,
       startTime,
       printTiming,
-      enqueueConfiguration,
+      testSuites,
       () => TestingServerRunner.terminateHttpServers(),
       verbose,
       listTests);
 }