Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 11882039: Also skip vm/dart/inline_stack_frame_test on ie9. (Closed)

Created:
7 years, 11 months ago by ricow1
Modified:
7 years, 11 months ago
Reviewers:
ahe, siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Also skip vm/dart/inline_stack_frame_test on ie9. There is no bug filed for this Revision 17000 changes the Skip to only apply to ff instead of all dart2js bots. Original review discussing the suppression: https://codereview.chromium.org//11784033 The ie9 failure on this was hidden by an already red bot. Committed: https://code.google.com/p/dart/source/detail?r=17045

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/tests/vm/vm.status View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 4 (0 generated)
ricow1
7 years, 11 months ago (2013-01-15 07:42:56 UTC) #1
ricow1
TBR
7 years, 11 months ago (2013-01-15 07:43:33 UTC) #2
ahe
Already submitted, so LGTM! https://codereview.chromium.org/11882039/diff/1/runtime/tests/vm/vm.status File runtime/tests/vm/vm.status (right): https://codereview.chromium.org/11882039/diff/1/runtime/tests/vm/vm.status#newcode37 runtime/tests/vm/vm.status:37: dart/inline_stack_frame_test: Skip Unless in exceptional ...
7 years, 11 months ago (2013-01-15 07:48:19 UTC) #3
ricow1
7 years, 11 months ago (2013-01-15 07:51:56 UTC) #4
Message was sent while issue was closed.
On 2013/01/15 07:48:19, ahe wrote:
> Already submitted, so LGTM!
> 
> https://codereview.chromium.org/11882039/diff/1/runtime/tests/vm/vm.status
> File runtime/tests/vm/vm.status (right):
> 
>
https://codereview.chromium.org/11882039/diff/1/runtime/tests/vm/vm.status#ne...
> runtime/tests/vm/vm.status:37: dart/inline_stack_frame_test: Skip
> Unless in exceptional circumstances, we should not skip tests on dart2js.
> 
> Since there is no comment here explaining why this test is exceptional, I
assume
> it should be marked "fail" instead.
That is what I assume as well, but since I did not know if there was some
strange reason for not marking this as failing in the first place I did not
change it (hence my request for a bug explaining this)

Siva: any reason why we should not just mark this as failing?

Powered by Google App Engine
This is Rietveld 408576698