Issue 11784033: Stack frame test probably shouldn't be running on a browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11784033: Stack frame test probably shouldn't be running on a browser. (Closed)

Created:
7 years, 11 months ago by Emily Fortuna

Modified:
7 years, 11 months ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Stack frame test probably shouldn't be running on a browser. BUG= Committed: https://code.google.com/p/dart/source/detail?r=16781

Patch Set 1 #

Total comments: 1

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	runtime/tests/vm/vm.status	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

siva

7 years, 11 months ago (2013-01-08 03:42:06 UTC) #2

Message was sent while issue was closed.

https://codereview.chromium.org/11784033/diff/1/runtime/tests/vm/vm.status
File runtime/tests/vm/vm.status (right):

https://codereview.chromium.org/11784033/diff/1/runtime/tests/vm/vm.status#ne...
runtime/tests/vm/vm.status:39: dart/inline_stack_frame_test: Skip
I think you should instead add a new category
[ $runtime == ff ]
dart/inline_stack_frame_test: Skip

This test passes on regular dart2js runs and it even works under chrome. Not
sure why it is failing under ff.

Expand Messages | Collapse Messages