Add --analyze-only flag to dart2js

Add --analyze-only flag to dart2js

Committed: https://code.google.com/p/dart/source/detail?r=17538

Committed: https://code.google.com/p/dart/source/detail?r=17545

[ahe, 2013-01-21 12:23:21]

You haven't actually added a flag that can be used from the command line, I
think you should.

Also, I'd like to see a test. I think you can do that with something similar to
dummy_compiler_test.

https://codereview.chromium.org/11882017/diff/3001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/compiler.dart (right):

https://codereview.chromium.org/11882017/diff/3001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/compiler.dart:657: if (!analyzeOnly) {
I think this should be:

if (mainApp != null) {

https://codereview.chromium.org/11882017/diff/3001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/compiler.dart:662: if
(!main.isFunction()) reportFatalError('main is not a function', main);
Long line.

https://codereview.chromium.org/11882017/diff/3001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/compiler.dart:673: if (analyzeAll ||
analyzeOnly) {
I don't think analyzeOnly should imply analyzeAll.

[Johnni Winther, 2013-01-22 16:06:55]

PTAL

https://codereview.chromium.org/11882017/diff/3001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/compiler.dart (right):

https://codereview.chromium.org/11882017/diff/3001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/compiler.dart:662: if
(!main.isFunction()) reportFatalError('main is not a function', main);
On 2013/01/21 12:23:21, ahe wrote:
> Long line.

Done.

https://codereview.chromium.org/11882017/diff/3001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/compiler.dart:673: if (analyzeAll ||
analyzeOnly) {
On 2013/01/21 12:23:21, ahe wrote:
> I don't think analyzeOnly should imply analyzeAll.

Done.

[ahe, 2013-01-23 11:07:44]

Did you add a test?

[Johnni Winther, 2013-01-23 11:12:16]

On 2013/01/23 11:07:44, ahe wrote:
> Did you add a test?

Forgot to. I'll ping you again.

[Johnni Winther, 2013-01-24 10:06:15]

PTAL

Test added.

https://codereview.chromium.org/11882017/diff/15001/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/compiler.dart (right):

https://codereview.chromium.org/11882017/diff/15001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/compiler.dart:673: mainApp);
This will allow us to analyze dart:core from the command line:

dart2js --analyze-only --analyze-all dart:core

[ahe, 2013-01-24 10:16:33]

LGTM!

https://codereview.chromium.org/11882017/diff/15001/tests/utils/analyze_only_...
File tests/utils/analyze_only_test.dart (right):

https://codereview.chromium.org/11882017/diff/15001/tests/utils/analyze_only_...
tests/utils/analyze_only_test.dart:6: library dummy_compiler;
Rename?

https://codereview.chromium.org/11882017/diff/15001/tests/utils/analyze_only_...
tests/utils/analyze_only_test.dart:13: Future<String> provider(Uri uri, String
mainSource) {
Can you import this from dummy_compiler_test?

[Johnni Winther, 2013-01-24 11:21:51]

https://codereview.chromium.org/11882017/diff/15001/tests/utils/analyze_only_...
File tests/utils/analyze_only_test.dart (right):

https://codereview.chromium.org/11882017/diff/15001/tests/utils/analyze_only_...
tests/utils/analyze_only_test.dart:6: library dummy_compiler;
On 2013/01/24 10:16:33, ahe wrote:
> Rename?

Done.

https://codereview.chromium.org/11882017/diff/15001/tests/utils/analyze_only_...
tests/utils/analyze_only_test.dart:13: Future<String> provider(Uri uri, String
mainSource) {
On 2013/01/24 10:16:33, ahe wrote:
> Can you import this from dummy_compiler_test?

Done.