Add --analyze-only flag to dart2js

sdk/lib/_internal/compiler/implementation/compiler.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart2js;
 
 /**
  * If true, print a warning for each method that was resolved, but not
  * compiled.
  */
@@ skipping 175 matching lines @@
   final bool enableMinification;
   final bool enableTypeAssertions;
   final bool enableUserAssertions;
   final bool enableConcreteTypeInference;
   /**
    * The maximum size of a concrete type before it widens to dynamic during
    * concrete type inference.
    */
   final int maxConcreteTypeSize;
   final bool analyzeAll;
+  final bool analyzeOnly;
   final bool enableNativeLiveTypeAnalysis;
   final bool rejectDeprecatedFeatures;
   final bool checkDeprecationInSdk;
 
   /**
    * If [:true:], comment tokens are collected in [commentMap] during scanning.
    */
   final bool preserveComments;
 
   bool disableInlining = false;
 
+  List<Uri> librariesToAnalyzeWhenRun;
+
   final Tracer tracer;
 
   CompilerTask measuredTask;
   Element _currentElement;
   LibraryElement coreLibrary;
   LibraryElement isolateLibrary;
   LibraryElement isolateHelperLibrary;
   LibraryElement jsHelperLibrary;
   LibraryElement interceptorsLibrary;
   LibraryElement foreignLibrary;
@@ skipping 100 matching lines @@
             this.enableTypeAssertions: false,
             this.enableUserAssertions: false,
             this.enableConcreteTypeInference: false,
             this.maxConcreteTypeSize: 5,
             this.enableMinification: false,
             this.enableNativeLiveTypeAnalysis: false,
             bool emitJavaScript: true,
             bool generateSourceMap: true,
             bool disallowUnsafeEval: false,
             this.analyzeAll: false,
+            this.analyzeOnly: false,
             this.rejectDeprecatedFeatures: false,
             this.checkDeprecationInSdk: false,
             this.preserveComments: false,
             List<String> strips: const []})
       : libraries = new Map<String, LibraryElement>(),
         progress = new Stopwatch() {
     progress.start();
     world = new World(this);
 
     closureMapping.ClosureNamer closureNamer;
@@ skipping 289 matching lines @@
     if (libraryName == 'dart:isolate'
         || libraryName == 'dart:html'
         // TODO(floitsch): create a separate async-helper library instead of
         // importing the isolate-library just for TimerImpl.
         || libraryName == 'dart:async') {
       importIsolateHelperLibrary(library);
     }
   }
 
   void runCompiler(Uri uri) {
-    log('compiling $uri ($BUILD_ID)');
+    assert(uri != null || analyzeOnly);
     scanBuiltinLibraries();
-    mainApp = libraryLoader.loadLibrary(uri, null, uri);
+    if (librariesToAnalyzeWhenRun != null) {
+      for (Uri libraryUri in librariesToAnalyzeWhenRun) {
+        log('analyzing $libraryUri ($BUILD_ID)');
+        libraryLoader.loadLibrary(libraryUri, null, libraryUri);
+      }
+    }
+    if (uri != null) {
+      log('compiling $uri ($BUILD_ID)');
+      mainApp = libraryLoader.loadLibrary(uri, null, uri);
+    }
     libraries.forEach((_, library) {
       maybeEnableJSHelper(library);
       maybeEnableIsolateHelper(library);
     });
-    final Element main = mainApp.find(MAIN);
-    if (main == null) {
-      reportFatalError('Could not find $MAIN', mainApp);
-    } else {
-      if (!main.isFunction()) reportFatalError('main is not a function', main);
-      FunctionElement mainMethod = main;
-      FunctionSignature parameters = mainMethod.computeSignature(this);
-      parameters.forEachParameter((Element parameter) {
-        reportFatalError('main cannot have parameters', parameter);
-      });
+    Element main = null;
+    if (!analyzeOnly) {

[ahe, 2013/01/21 12:23:21]

I think this should be:

if (mainApp != null) {

+      main = mainApp.find(MAIN);
+      if (main == null) {
+        reportFatalError('Could not find $MAIN', mainApp);
+      } else {
+        if (!main.isFunction()) reportFatalError('main is not a function', main);

[ahe, 2013/01/21 12:23:21]

Long line.

[Johnni Winther, 2013/01/22 16:06:55]

Done.

+        FunctionElement mainMethod = main;
+        FunctionSignature parameters = mainMethod.computeSignature(this);
+        parameters.forEachParameter((Element parameter) {
+          reportFatalError('main cannot have parameters', parameter);
+        });
+      }
     }
 
     log('Resolving...');
     phase = PHASE_RESOLVING;
-    if (analyzeAll) libraries.forEach((_, lib) => fullyEnqueueLibrary(lib));
+    if (analyzeAll || analyzeOnly) {

[ahe, 2013/01/21 12:23:21]

I don't think analyzeOnly should imply analyzeAll.

[Johnni Winther, 2013/01/22 16:06:55]

Done.

+      libraries.forEach((_, lib) => fullyEnqueueLibrary(lib));
+    }
     backend.enqueueHelpers(enqueuer.resolution);
     processQueue(enqueuer.resolution, main);
     enqueuer.resolution.logSummary(log);
 
     if (compilationFailed) return;
+    if (analyzeOnly) return;
+    assert(main != null);
 
     log('Inferring types...');
     typesTask.onResolutionComplete(main);
 
     // TODO(ahe): Remove this line. Eventually, enqueuer.resolution
     // should know this.
     world.populate();
 
     log('Compiling...');
     phase = PHASE_COMPILING;
@@ skipping 19 matching lines @@
 
   void fullyEnqueueLibrary(LibraryElement library) {
     library.forEachLocalMember(fullyEnqueueTopLevelElement);
   }
 
   void fullyEnqueueTopLevelElement(Element element) {
     if (element.isClass()) {
       ClassElement cls = element;
       cls.ensureResolved(this);
       cls.forEachLocalMember(enqueuer.resolution.addToWorkList);
+    } else if (element.isTypedef()) {
+      TypedefElement typdef = element;
+      typdef.computeType(this);
     } else {
       enqueuer.resolution.addToWorkList(element);
     }
   }
 
   void processQueue(Enqueuer world, Element main) {
     world.nativeEnqueuer.processNativeClasses(libraries.values);
-    world.addToWorkList(main);
+    if (main != null) {
+      world.addToWorkList(main);
+    }
     progress.reset();
     world.forEach((WorkItem work) {
       withCurrentElement(work.element, () => work.run(this, world));
     });
     world.queueIsClosed = true;
     if (compilationFailed) return;
     assert(world.checkNoEnqueuedInvokedInstanceMethods());
     if (DUMP_INFERRED_TYPES && phase == PHASE_COMPILING) {
       backend.dumpInferredTypes();
     }
@@ skipping 358 matching lines @@
   // TODO(johnniwinther): Use [spannable] and [message] to provide better
   // information on assertion errors.
   if (condition is Function){
     condition = condition();
   }
   if (spannable == null || !condition) {
     throw new SpannableAssertionFailure(spannable, message);
   }
   return true;
 }