Issue 1188103002: Do not mark type variables as needing a box inside try; they are immutable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1188103002: Do not mark type variables as needing a box inside try; they are immutable. (Closed)

Created:
5 years, 6 months ago by karlklose

Modified:
5 years, 6 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Do not mark type variables as needing a box inside try; they are immutable. Closes #23650 R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/551fa1fdaa14904e67204871382e61859bf54de2

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -12 lines)			Patch
M	pkg/compiler/lib/src/closure.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/ssa/builder.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
A +	tests/language/regress_23650_test.dart	View	1 chunk	+13 lines, -9 lines	0 comments	Download
M	tests/lib/lib.status	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

karlklose

5 years, 6 months ago (2015-06-16 12:13:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
551fa1fdaa14904e67204871382e61859bf54de2 (presubmit successful).