Issue 11880022: Immediate index operand for string [] and streamline code for generating array ops.

Issue 11880022: Immediate index operand for string [] and streamline code for generating array ops. (Closed)

Created:
7 years, 11 months ago by Florian Schneider

Modified:
7 years, 11 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Immediate index operand for string [] and streamline code for generating array ops. Replace sizeof(RawArray) with Array::data_offset where it is used to compute the start of the array data. Refactor helpers for generating array addressing mode and use them for string [] operations as well. Committed: https://code.google.com/p/dart/source/detail?r=17019

Patch Set 1 #

Total comments: 4

Patch Set 2 : addressed comments #

Patch Set 3 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+127 lines, -81 lines)			Patch
M	runtime/vm/flow_graph_compiler.cc	View	1 2	2 chunks	+59 lines, -33 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1	5 chunks	+27 lines, -19 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2	5 chunks	+27 lines, -19 lines	0 comments	Download
M	runtime/vm/intrinsifier_ia32.cc	View		5 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/vm/intrinsifier_x64.cc	View		5 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

lgtm https://codereview.chromium.org/11880022/diff/1/runtime/vm/intermediate_language_ia32.cc File runtime/vm/intermediate_language_ia32.cc (right): https://codereview.chromium.org/11880022/diff/1/runtime/vm/intermediate_language_ia32.cc#newcode1065 runtime/vm/intermediate_language_ia32.cc:1065: return Utils::IsInt(31, disp); I think this should be ...

7 years, 11 months ago (2013-01-14 16:39:55 UTC) #2

Florian Schneider

7 years, 11 months ago (2013-01-14 17:00:47 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/11880022/diff/1/runtime/vm/intermediate_langu...
File runtime/vm/intermediate_language_ia32.cc (right):

https://codereview.chromium.org/11880022/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language_ia32.cc:1065: return Utils::IsInt(31, disp);
On 2013/01/14 16:39:56, Vyacheslav Egorov (Google) wrote:
> I think this should be 32 and the same in other places.

Done.

https://codereview.chromium.org/11880022/diff/1/runtime/vm/intermediate_langu...
File runtime/vm/intermediate_language_x64.cc (right):

https://codereview.chromium.org/11880022/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language_x64.cc:929: return Utils::IsInt(31, disp);
On 2013/01/14 16:39:56, Vyacheslav Egorov (Google) wrote:
> 32?

Done.

Expand Messages | Collapse Messages