Immediate index operand for string [] and streamline code for generating array ops.

runtime/vm/intermediate_language_ia32.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/intermediate_language.h"
 
 #include "lib/error.h"
@@ skipping 1036 matching lines @@
   __ movl(ECX, Immediate(reinterpret_cast<uword>(native_c_function())));
   __ movl(EDX, Immediate(NativeArguments::ComputeArgcTag(function())));
   compiler->GenerateCall(token_pos(),
                          &StubCode::CallNativeCFunctionLabel(),
                          PcDescriptors::kOther,
                          locs());
   __ popl(result);
 }
 
 
-static bool CanBeImmediateIndex(Value* index) {
+static bool CanBeImmediateIndex(Value* index, intptr_t cid) {
   if (!index->definition()->IsConstant()) return false;
   const Object& constant = index->definition()->AsConstant()->value();
   if (!constant.IsSmi()) return false;
   const Smi& smi_const = Smi::Cast(constant);
-  int64_t disp = smi_const.AsInt64Value() * kWordSize + sizeof(RawArray);
+  const intptr_t scale = FlowGraphCompiler::ElementSizeFor(cid);
+  const intptr_t data_offset = FlowGraphCompiler::DataOffsetFor(cid);
+  const int64_t disp = smi_const.AsInt64Value() * scale + data_offset;
   return Utils::IsInt(32, disp);
 }
 
 
 LocationSummary* StringCharCodeAtInstr::MakeLocationSummary() const {
   const intptr_t kNumInputs = 2;
   const intptr_t kNumTemps = 0;
   LocationSummary* locs =
       new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
   locs->set_in(0, Location::RequiresRegister());
-  // TODO(fschneider): Allow immediate operands for the index.
-  locs->set_in(1, Location::RequiresRegister());
+  locs->set_in(1, CanBeImmediateIndex(index(), class_id())
+                    ? Location::RegisterOrSmiConstant(index())
+                    : Location::RequiresRegister());
   locs->set_out(Location::RequiresRegister());
   return locs;
 }
 
 
 void StringCharCodeAtInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
   Register str = locs()->in(0).reg();
-  Register index = locs()->in(1).reg();
+  Location index = locs()->in(1);
   Register result = locs()->out().reg();
 
   ASSERT((class_id() == kOneByteStringCid) ||
          (class_id() == kTwoByteStringCid));
+
+  FieldAddress element_address = index.IsRegister() ?
+      FlowGraphCompiler::ElementAddressForRegIndex(
+          class_id(), str, index.reg()) :
+      FlowGraphCompiler::ElementAddressForIntIndex(
+          class_id(), str, Smi::Cast(index.constant()).Value());
+
   if (class_id() == kOneByteStringCid) {
-    __ SmiUntag(index);
-    __ movzxb(result, FieldAddress(str,
-                                   index,
-                                   TIMES_1,
-                                   OneByteString::data_offset()));
-    __ SmiTag(index);  // Retag index.
+    if (index.IsRegister()) {
+      __ SmiUntag(index.reg());
+    }
+    __ movzxb(result, element_address);
+    if (index.IsRegister()) {
+      __ SmiTag(index.reg());  // Retag index.
+    }
     __ SmiTag(result);
   } else {
     // Don't untag smi-index and use TIMES_1 for two byte strings.
-    __ movzxw(result, FieldAddress(str,
-                                   index,
-                                   TIMES_1,
-                                   TwoByteString::data_offset()));
+    __ movzxw(result, element_address);
     __ SmiTag(result);
   }
 }
 
 
 LocationSummary* StringFromCharCodeInstr::MakeLocationSummary() const {
   const intptr_t kNumInputs = 1;
   const intptr_t kNumTemps = 0;
   LocationSummary* locs =
       new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
@@ skipping 15 matching lines @@
                           Symbols::kNullCharCodeSymbolOffset * kWordSize));
 }
 
 
 LocationSummary* LoadIndexedInstr::MakeLocationSummary() const {
   const intptr_t kNumInputs = 2;
   const intptr_t kNumTemps = 0;
   LocationSummary* locs =
       new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
   locs->set_in(0, Location::RequiresRegister());
-  locs->set_in(1, CanBeImmediateIndex(index())
-                    ? Location::RegisterOrConstant(index())
+  locs->set_in(1, CanBeImmediateIndex(index(), class_id())
+                    ? Location::RegisterOrSmiConstant(index())
                     : Location::RequiresRegister());
   if (representation() == kUnboxedDouble) {
     locs->set_out(Location::RequiresXmmRegister());
   } else {
     locs->set_out(Location::RequiresRegister());
   }
   return locs;
 }
 
 
@@ skipping 59 matching lines @@
   __ movl(result, element_address);
 }
 
 
 LocationSummary* StoreIndexedInstr::MakeLocationSummary() const {
   const intptr_t kNumInputs = 3;
   const intptr_t kNumTemps = 0;
   LocationSummary* locs =
       new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
   locs->set_in(0, Location::RequiresRegister());
-  locs->set_in(1, CanBeImmediateIndex(index())
-                    ? Location::RegisterOrConstant(index())
+  locs->set_in(1, CanBeImmediateIndex(index(), class_id())
+                    ? Location::RegisterOrSmiConstant(index())
                     : Location::RequiresRegister());
   switch (class_id()) {
     case kArrayCid:
       locs->set_in(2, ShouldEmitStoreBarrier()
                         ? Location::WritableRegister()
                         : Location::RegisterOrConstant(value()));
       break;
     case kUint8ArrayCid:
       // TODO(fschneider): Add location constraint for byte registers (EAX,
       // EBX, ECX, EDX) instead of using a fixed register.
@@ skipping 1623 matching lines @@
   __ pcmpeqq(XMM0, XMM0);  // Generate all 1's.
   __ pxor(value, XMM0);
 }
 
 
 }  // namespace dart
 
 #undef __
 
 #endif  // defined TARGET_ARCH_X64