Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 11865005: Remove Futures class, move methods to Future. (Closed)

Created:
7 years, 11 months ago by Lasse Reichstein Nielsen
Modified:
7 years, 11 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove Futures class, move methods to Future. Optimize Future.forEach, Future.delay. Committed: https://code.google.com/p/dart/source/detail?r=16954

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -107 lines) Patch
M pkg/http/lib/src/io_client.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/http/lib/src/multipart_request.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/intl/example/basic/basic_example.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/intl/lib/date_symbol_data_file.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/intl/lib/date_symbol_data_http_request.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/intl/test/date_time_format_file_test_stub.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/intl/test/date_time_format_http_request_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/intl/test/date_time_format_local_test_stub.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/dartcombat/state.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/solar3d/web/solar.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/solar3d/web/texture_manager.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/dartdoc/bin/dartdoc.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M sdk/lib/async/future.dart View 2 chunks +48 lines, -38 lines 0 comments Download
M tests/lib/async/future_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/futures_test.dart View 8 chunks +10 lines, -10 lines 0 comments Download
M tests/standalone/io/directory_create_race_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/directory_fuzz_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/file_fuzz_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/io/http_auth_test.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M tests/standalone/io/http_session_test.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M tools/html_json_doc/lib/html_to_json.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M tools/testing/dart/multitest.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/test_runner.dart View 1 chunk +1 line, -0 lines 0 comments Download
M utils/apidoc/apidoc.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M utils/archive/entry.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/archive/input_stream.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/archive/reader.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/command_lish.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/pub/curl_client.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/entrypoint.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M utils/pub/hosted_source.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/io.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/pub/validator.dart View 1 chunk +1 line, -1 line 0 comments Download
utils/pub/validator/dependency.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/validator/directory.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/version_solver.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/test_pub.dart View 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lasse Reichstein Nielsen
7 years, 11 months ago (2013-01-11 09:25:02 UTC) #1
floitsch
7 years, 11 months ago (2013-01-11 09:32:18 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698