Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Side by Side Diff: utils/pub/validator/dependency.dart

Issue 11865005: Remove Futures class, move methods to Future. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « utils/pub/validator.dart ('k') | utils/pub/validator/directory.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library dependency_validator; 5 library dependency_validator;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 8
9 import '../entrypoint.dart'; 9 import '../entrypoint.dart';
10 import '../hosted_source.dart'; 10 import '../hosted_source.dart';
11 import '../http.dart'; 11 import '../http.dart';
12 import '../package.dart'; 12 import '../package.dart';
13 import '../utils.dart'; 13 import '../utils.dart';
14 import '../validator.dart'; 14 import '../validator.dart';
15 import '../version.dart'; 15 import '../version.dart';
16 16
17 /// A validator that validates a package's dependencies. 17 /// A validator that validates a package's dependencies.
18 class DependencyValidator extends Validator { 18 class DependencyValidator extends Validator {
19 DependencyValidator(Entrypoint entrypoint) 19 DependencyValidator(Entrypoint entrypoint)
20 : super(entrypoint); 20 : super(entrypoint);
21 21
22 Future validate() { 22 Future validate() {
23 return Futures.forEach(entrypoint.root.pubspec.dependencies, (dependency) { 23 return Future.forEach(entrypoint.root.pubspec.dependencies, (dependency) {
24 if (dependency.source is! HostedSource) { 24 if (dependency.source is! HostedSource) {
25 return _warnAboutSource(dependency); 25 return _warnAboutSource(dependency);
26 } 26 }
27 27
28 if (dependency.name == entrypoint.root.name) { 28 if (dependency.name == entrypoint.root.name) {
29 warnings.add('You don\'t need to explicitly depend on your own ' 29 warnings.add('You don\'t need to explicitly depend on your own '
30 'package.\n' 30 'package.\n'
31 'Pub enables "package:${entrypoint.root.name}" imports ' 31 'Pub enables "package:${entrypoint.root.name}" imports '
32 'implicitly.'); 32 'implicitly.');
33 return new Future.immediate(null); 33 return new Future.immediate(null);
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 } 92 }
93 93
94 /// Returns the suggested version constraint for a dependency that was tested 94 /// Returns the suggested version constraint for a dependency that was tested
95 /// against [version]. 95 /// against [version].
96 String _constraintForVersion(Version version) { 96 String _constraintForVersion(Version version) {
97 if (version.major != 0) return '">=$version <${version.major + 1}.0.0"'; 97 if (version.major != 0) return '">=$version <${version.major + 1}.0.0"';
98 return '">=$version <${version.major}.${version.minor}.' 98 return '">=$version <${version.major}.${version.minor}.'
99 '${version.patch + 1}"'; 99 '${version.patch + 1}"';
100 } 100 }
101 } 101 }
OLDNEW
« no previous file with comments | « utils/pub/validator.dart ('k') | utils/pub/validator/directory.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698