OLD | NEW |
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file | 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file |
2 // for details. All rights reserved. Use of this source code is governed by a | 2 // for details. All rights reserved. Use of this source code is governed by a |
3 // BSD-style license that can be found in the LICENSE file. | 3 // BSD-style license that can be found in the LICENSE file. |
4 | 4 |
5 library dependency_validator; | 5 library dependency_validator; |
6 | 6 |
7 import 'dart:async'; | 7 import 'dart:async'; |
8 | 8 |
9 import '../entrypoint.dart'; | 9 import '../entrypoint.dart'; |
10 import '../hosted_source.dart'; | 10 import '../hosted_source.dart'; |
11 import '../http.dart'; | 11 import '../http.dart'; |
12 import '../package.dart'; | 12 import '../package.dart'; |
13 import '../utils.dart'; | 13 import '../utils.dart'; |
14 import '../validator.dart'; | 14 import '../validator.dart'; |
15 import '../version.dart'; | 15 import '../version.dart'; |
16 | 16 |
17 /// A validator that validates a package's dependencies. | 17 /// A validator that validates a package's dependencies. |
18 class DependencyValidator extends Validator { | 18 class DependencyValidator extends Validator { |
19 DependencyValidator(Entrypoint entrypoint) | 19 DependencyValidator(Entrypoint entrypoint) |
20 : super(entrypoint); | 20 : super(entrypoint); |
21 | 21 |
22 Future validate() { | 22 Future validate() { |
23 return Futures.forEach(entrypoint.root.pubspec.dependencies, (dependency) { | 23 return Future.forEach(entrypoint.root.pubspec.dependencies, (dependency) { |
24 if (dependency.source is! HostedSource) { | 24 if (dependency.source is! HostedSource) { |
25 return _warnAboutSource(dependency); | 25 return _warnAboutSource(dependency); |
26 } | 26 } |
27 | 27 |
28 if (dependency.name == entrypoint.root.name) { | 28 if (dependency.name == entrypoint.root.name) { |
29 warnings.add('You don\'t need to explicitly depend on your own ' | 29 warnings.add('You don\'t need to explicitly depend on your own ' |
30 'package.\n' | 30 'package.\n' |
31 'Pub enables "package:${entrypoint.root.name}" imports ' | 31 'Pub enables "package:${entrypoint.root.name}" imports ' |
32 'implicitly.'); | 32 'implicitly.'); |
33 return new Future.immediate(null); | 33 return new Future.immediate(null); |
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
92 } | 92 } |
93 | 93 |
94 /// Returns the suggested version constraint for a dependency that was tested | 94 /// Returns the suggested version constraint for a dependency that was tested |
95 /// against [version]. | 95 /// against [version]. |
96 String _constraintForVersion(Version version) { | 96 String _constraintForVersion(Version version) { |
97 if (version.major != 0) return '">=$version <${version.major + 1}.0.0"'; | 97 if (version.major != 0) return '">=$version <${version.major + 1}.0.0"'; |
98 return '">=$version <${version.major}.${version.minor}.' | 98 return '">=$version <${version.major}.${version.minor}.' |
99 '${version.patch + 1}"'; | 99 '${version.patch + 1}"'; |
100 } | 100 } |
101 } | 101 } |
OLD | NEW |