Fix optional arguments handling. Handling of default values is for a further

Fix optional arguments handling. Handling of default values is for a further
CL: this CL only aims at catching up with the changes in the spec.

Committed: https://code.google.com/p/dart/source/detail?r=17189

[karlklose, 2013-01-15 09:54:51]

LGTM, but I think we could get rid of duplicated signature checks by using
Selector.applies.

https://codereview.chromium.org/11863007/diff/1/sdk/lib/_internal/compiler/im...
File
sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart
(right):

https://codereview.chromium.org/11863007/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart:679:
// guard 1: too many arguments
Could we use selectors for these checks?

https://codereview.chromium.org/11863007/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart:729:
// unexisting or already used named parameter
If we used selector.applies instead of the guards above, this would also be
checked.

https://codereview.chromium.org/11863007/diff/1/tests/compiler/dart2js/cpa_in...
File tests/compiler/dart2js/cpa_inference_test.dart (right):

https://codereview.chromium.org/11863007/diff/1/tests/compiler/dart2js/cpa_in...
tests/compiler/dart2js/cpa_inference_test.dart:514:
testOptionalNamedParameters() {
Perhaps you should add a few tests using methods instead of constructors.

[polux, 2013-01-17 09:14:27]

https://chromiumcodereview.appspot.com/11863007/diff/1/sdk/lib/_internal/comp...
File
sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart
(right):

https://chromiumcodereview.appspot.com/11863007/diff/1/sdk/lib/_internal/comp...
sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart:679:
// guard 1: too many arguments
On 2013/01/15 09:54:51, karlklose wrote:
> Could we use selectors for these checks?

We could (and should) use selectors there. However, unless I missed something in
the way you obtain a selector, that seems like a pretty big change. I.e. it
looks to me you can get a selector out of a Node, but not a FunctionElement but
the code of the inferrer is passing around FunctionElements everywhere, not
nodes.

So unless I'm mistaken, I propose we submit this CL as is and we migrate to
selectors in a separate CL.

https://chromiumcodereview.appspot.com/11863007/diff/1/tests/compiler/dart2js...
File tests/compiler/dart2js/cpa_inference_test.dart (right):

https://chromiumcodereview.appspot.com/11863007/diff/1/tests/compiler/dart2js...
tests/compiler/dart2js/cpa_inference_test.dart:514:
testOptionalNamedParameters() {
On 2013/01/15 09:54:51, karlklose wrote:
> Perhaps you should add a few tests using methods instead of constructors.

Done.