Fix optional arguments handling. Handling of default values is for a further

tests/compiler/dart2js/cpa_inference_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import "dart:uri";
 import "../../../sdk/lib/_internal/compiler/implementation/elements/elements.dart";
 import '../../../sdk/lib/_internal/compiler/implementation/scanner/scannerlib.dart';
 import '../../../sdk/lib/_internal/compiler/implementation/source_file.dart';
 import '../../../sdk/lib/_internal/compiler/implementation/types/types.dart';
 import '../../../sdk/lib/_internal/compiler/implementation/tree/tree.dart';
@@ skipping 493 matching lines @@
                             result.string,    // a.x = 'abc'
                             result.bool,      // a.y = true
                             result.nullType,  // dynamic.x = null
                             result.double]);  // dynamic.y = 3.14
   result.checkFieldHasType('A', 'w',
                            [result.int,       // new A(..., 42)
                             result.bool,      // a.y = true
                             result.double]);  // dynamic.y = double
 }
 
-testNamedParameters() {
+testOptionalNamedParameters() {

[karlklose, 2013/01/15 09:54:51]

Perhaps you should add a few tests using methods instead of constructors.

[polux, 2013/01/17 09:14:27]

Done.

   final String source = r"""
       class A {
         var x, y, z, w;
         A(this.x, {this.y, this.z, this.w});
       }
+      class B {
+        var x, y;
+        B(this.x, {this.y});
+      }
+      class C {
+        var x, y;
+        C(this.x, {this.y});
+      }
       main() {
         new A(42);
         new A('abc', w: true, z: 42.0);
+        new B('abc', y: true);
+        new B(1, 2);  // too many positional arguments
+        new C('abc', y: true);
+        new C(1, z: 2);  // non-existing named parameter
       }
       """;
   AnalysisResult result = analyze(source);
   result.checkFieldHasType('A', 'x', [result.int, result.string]);
   result.checkFieldHasType('A', 'y', [new NullBaseType()]);
   result.checkFieldHasType('A', 'z', [new NullBaseType(), result.double]);
   result.checkFieldHasType('A', 'w', [new NullBaseType(), result.bool]);
+  result.checkFieldHasType('B', 'x', [result.string]);
+  result.checkFieldHasType('B', 'y', [result.bool]);
+  result.checkFieldHasType('C', 'x', [result.string]);
+  result.checkFieldHasType('C', 'y', [result.bool]);
+}
+
+testOptionalPositionalParameters() {
+  final String source = r"""
+    class A {
+      var x, y, z, w;
+      A(this.x, [this.y, this.z, this.w]);
+    }
+    class B {
+      var x, y;
+      B(this.x, [this.y]);
+    }
+    main() {
+      new A(42);
+      new A('abc', true, 42.0);
+      new B('a', true);
+      new B(1, 2, 3);  // too many arguments
+    }
+  """;
+  AnalysisResult result = analyze(source);
+  result.checkFieldHasType('A', 'x', [result.int, result.string]);
+  result.checkFieldHasType('A', 'y', [new NullBaseType(), result.bool]);
+  result.checkFieldHasType('A', 'z', [new NullBaseType(), result.double]);
+  result.checkFieldHasType('A', 'w', [new NullBaseType()]);
+  result.checkFieldHasType('B', 'x', [result.string]);
+  result.checkFieldHasType('B', 'y', [result.bool]);
 }
 
 testListLiterals() {
   final String source = r"""
       class A {
         var x;
         A(this.x);
       }
       main() {
         var x = [];
@@ skipping 314 matching lines @@
   testNonRecusiveFunction();
   testRecusiveFunction();
   testMutuallyRecusiveFunction();
   testSimpleSend();
   // testSendToClosureField();  // closures are not yet supported
   testSendToThis1();
   testSendToThis2();
   testConstructor();
   testGetters();
   testSetters();
-  testNamedParameters();
+  testOptionalNamedParameters();
+  testOptionalPositionalParameters();
   testListLiterals();
   testMapLiterals();
   testReturn();
   // testNoReturn(); // right now we infer the empty type instead of null
   testArithmeticOperators();
   testOperators();
   testCompoundOperators1();
   testCompoundOperators2();
   testSetIndexOperator();
   testInequality();
   // testFieldInitialization(); // TODO(polux)
   testSendWithWrongArity();
   testBigTypesWidening1();
   testBigTypesWidening2();
   testDynamicIsAbsorbing();
 }