Issue 1186113011: Some cleanup and be more conservative when guessing cids: use only current leaf classes; otherwise …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1186113011: Some cleanup and be more conservative when guessing cids: use only current leaf classes; otherwise … (Closed)

Created:
5 years, 6 months ago by srdjan

Modified:
5 years, 6 months ago

Reviewers:
Florian Schneider, rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Some cleanup and be more conservative when guessing cids: use only current leaf classes; otherwise we may get the cid of e.g., _StringBase, which confuses the VM since an object of that cid is never instantiated. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/5ce63657afb811e2856af1617895cbec15900d4e

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -16 lines)			Patch
M	runtime/vm/cha.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/cha.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/cha_test.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	3 chunks	+5 lines, -4 lines	0 comments	Download
M	runtime/vm/flow_graph_type_propagator.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 5 (2 generated)

srdjan

5 years, 6 months ago (2015-06-19 17:17:06 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
5ce63657afb811e2856af1617895cbec15900d4e (presubmit successful).