Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Side by Side Diff: runtime/vm/cha.h

Issue 1186113011: Some cleanup and be more conservative when guessing cids: use only current leaf classes; otherwise … (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: y Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | runtime/vm/cha.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_CHA_H_ 5 #ifndef VM_CHA_H_
6 #define VM_CHA_H_ 6 #define VM_CHA_H_
7 7
8 #include "vm/allocation.h" 8 #include "vm/allocation.h"
9 #include "vm/growable_array.h" 9 #include "vm/growable_array.h"
10 #include "vm/thread.h" 10 #include "vm/thread.h"
(...skipping 14 matching lines...) Expand all
25 previous_(thread->cha()) { 25 previous_(thread->cha()) {
26 thread->set_cha(this); 26 thread->set_cha(this);
27 } 27 }
28 28
29 ~CHA() { 29 ~CHA() {
30 ASSERT(thread_->cha() == this); 30 ASSERT(thread_->cha() == this);
31 thread_->set_cha(previous_); 31 thread_->set_cha(previous_);
32 } 32 }
33 33
34 // Returns true if the class has subclasses. 34 // Returns true if the class has subclasses.
35 bool HasSubclasses(const Class& cls); 35 static bool HasSubclasses(const Class& cls);
36 bool HasSubclasses(intptr_t cid); 36 bool HasSubclasses(intptr_t cid) const;
37 37
38 // Return true if the class is implemented by some other class. 38 // Return true if the class is implemented by some other class.
39 bool IsImplemented(const Class& cls); 39 static bool IsImplemented(const Class& cls);
40 40
41 // Returns true if any subclass of 'cls' contains the function. 41 // Returns true if any subclass of 'cls' contains the function.
42 bool HasOverride(const Class& cls, const String& function_name); 42 bool HasOverride(const Class& cls, const String& function_name);
43 43
44 const GrowableArray<Class*>& leaf_classes() const { 44 const GrowableArray<Class*>& leaf_classes() const {
45 return leaf_classes_; 45 return leaf_classes_;
46 } 46 }
47 47
48 // Adds class 'cls' to the list of guarded leaf classes, deoptimization occurs 48 // Adds class 'cls' to the list of guarded leaf classes, deoptimization occurs
49 // if any of those leaf classes gets subclassed through later loaded/finalized 49 // if any of those leaf classes gets subclassed through later loaded/finalized
50 // libraries. Only classes that were used for CHA optimizations are added. 50 // libraries. Only classes that were used for CHA optimizations are added.
51 void AddToLeafClasses(const Class& cls); 51 void AddToLeafClasses(const Class& cls);
52 52
53 private: 53 private:
54 Thread* thread_; 54 Thread* thread_;
55 GrowableArray<Class*> leaf_classes_; 55 GrowableArray<Class*> leaf_classes_;
56 CHA* previous_; 56 CHA* previous_;
57 }; 57 };
58 58
59 } // namespace dart 59 } // namespace dart
60 60
61 #endif // VM_CHA_H_ 61 #endif // VM_CHA_H_
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/cha.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698