Issue 11859012: Change how to opt-in to dart2js mirrors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11859012: Change how to opt-in to dart2js mirrors. (Closed)

Created:
7 years, 11 months ago by ahe

Modified:
7 years, 11 months ago

Reviewers:
sra1, kasperl

CC:
reviews_dartlang.org, sra1, erikcorry, aam-me

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Change how to opt-in to dart2js mirrors. Committed: https://code.google.com/p/dart/source/detail?r=17042

Patch Set 2 : Address review comments #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -33 lines)			Patch
M	dart/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart	View		3 chunks	+1 line, -8 lines	0 comments	Download
D	dart/sdk/lib/_internal/compiler/implementation/lib/mirror_opt_in_message.dart	View		1 chunk	+0 lines, -20 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart	View	1	3 chunks	+24 lines, -4 lines	0 comments	Download
M	dart/tests/compiler/dart2js_extra/mirror_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sra1

lgtm. Thanks for doing this. https://codereview.chromium.org/11859012/diff/1/dart/sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart File dart/sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart (right): https://codereview.chromium.org/11859012/diff/1/dart/sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart#newcode38 dart/sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart:38: if ((_MIRROR_OPT_IN_MESSAGE == reflectee)) ...

7 years, 11 months ago (2013-01-12 12:50:22 UTC) #2

ahe

7 years, 11 months ago (2013-01-16 13:36:13 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/11859012/diff/1/dart/sdk/lib/_internal/compil...
File dart/sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart
(right):

https://codereview.chromium.org/11859012/diff/1/dart/sdk/lib/_internal/compil...
dart/sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart:38: if
((_MIRROR_OPT_IN_MESSAGE == reflectee)) {
On 2013/01/12 12:50:22, sra1 wrote:
> Perhaps add  && !_mirrorsEnabled just in case the string is reflected for
real.

Done.

Expand Messages | Collapse Messages

Issue 11859012: Change how to opt-in to dart2js mirrors. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address review comments #

Messages