dart/sdk/lib/_internal/compiler/implementation/lib/mirror_opt_in_message.dart - Issue 11859012: Change how to opt-in to dart2js mirrors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/lib/mirror_opt_in_message.dart

Issue 11859012: Change how to opt-in to dart2js mirrors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Address review comments Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « dart/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart ('k') | dart/sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: dart/sdk/lib/_internal/compiler/implementation/lib/mirror_opt_in_message.dart

diff --git a/dart/sdk/lib/_internal/compiler/implementation/lib/mirror_opt_in_message.dart b/dart/sdk/lib/_internal/compiler/implementation/lib/mirror_opt_in_message.dart

deleted file mode 100644

index b9743de8f767e647ebe8b6f49efb7a0d688f9a82..0000000000000000000000000000000000000000

--- a/dart/sdk/lib/_internal/compiler/implementation/lib/mirror_opt_in_message.dart

+++ /dev/null

@@ -1,20 +0,0 @@

-// BSD-style license that can be found in the LICENSE file.

-part of _js_helper;

-// Yeah, seriously: mirrors in dart2js are experimental...

-const String MIRROR_OPT_IN_MESSAGE = """

-This program is using an experimental feature called \"mirrors\". As

-currently implemented, mirrors do not work with minification, and will

-cause spurious errors depending on how code was optimized.

-The authors of this program are aware of these problems and have

-decided the thrill of using an experimental feature is outweighing the

-risks. Furthermore, the authors of this program understand that

-long-term, to fix the problems mentioned above, mirrors may have

-negative impact on size and performance of Dart programs compiled to

-JavaScript.

-""";